Skip to content

ImageFilter.compose: sampling outside of inner has backend differences #177795

@gaaclarke

Description

@gaaclarke

The differences have to do with taking away the extra 1 pixel padding from the RenderToSnapshot introduced in #177687. The differences show up in ComposePaintRuntimeInner and ComposePaintRuntimeOuter tests. The output I would expect is actually opengles in this case, the vulkan and metal outputs look wrong.

This removal of the padding was required to get pixel perfect fragment shading coordinates until we can potentially pass a transform into the ImageFilter.shader shader to represent the offset.

ComposePaintRuntimeInner

vulkan

Image

opengles

Image

metal

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions