Skip to content

Dark theme elevation overlay should be based off of colorScheme.onSurface #41826

@darrenaustin

Description

@darrenaustin

The Material Dark Theme spec has been updated (or soon will be) to clarify that the elevation overlay that is applied to surface colors to indicate elevation should be based off of the colorScheme.onSurface color and not white.

This is simple to fix, but will potentially break apps that were depending on it being white and not the onSurface color. This is likely of minimal impact, as this feature was just introduced and if an app is using the base Material dark theme (i.e. using ColorScheme.dark()), the surface color is white so there won't be any visible difference.

Metadata

Metadata

Assignees

Labels

c: API breakBackwards-incompatible API changesf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions