Skip to content

Run CADisableMinimumFrameDurationOnPhone migration on all example apps#101314

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:CADisableMinimumFrameDurationOnPhone
Apr 5, 2022
Merged

Run CADisableMinimumFrameDurationOnPhone migration on all example apps#101314
jmagman merged 1 commit intoflutter:masterfrom
jmagman:CADisableMinimumFrameDurationOnPhone

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Apr 4, 2022

Run #100647 migration on all iOS example/test apps in the repo so building them locally doesn't dirty anything in the working copy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. d: examples Sample code and demos labels Apr 4, 2022
@jmagman jmagman self-assigned this Apr 4, 2022
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ documentation f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 4, 2022
@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman jmagman requested a review from cyanglaz April 4, 2022 22:23
@Hixie
Copy link
Copy Markdown
Contributor

Hixie commented Apr 4, 2022

test-exempt: configuration change

but for bonus points, we should have a test that verifies that running the examples doesn't dirty the repo.

Copy link
Copy Markdown
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Apr 5, 2022

Google testing is borked, merging.

@jmagman jmagman merged commit 5788f5e into flutter:master Apr 5, 2022
@jmagman jmagman deleted the CADisableMinimumFrameDurationOnPhone branch April 5, 2022 22:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants