Fix a couple of strong mode issues.#14070
Merged
mraleph merged 1 commit intoflutter:masterfrom Jan 13, 2018
Merged
Conversation
* JSON.decode produces Map<String, dynamic> and List<dynamic> objects. If a more tight type is required then object needs to be converted explicitly (see dart-lang/sdk#31876); * Completer<dynamic> produces Future<dynamic>. In Dart 2 it is runtime error to assign Future<dynamic> to variable of type Future<T>;
Hixie
reviewed
Jan 12, 2018
| // completer for it to use when it does run. | ||
| completer = new Completer<dynamic>(); | ||
| completer = new Completer<T>(); | ||
| _structuredDataCache[key] = completer.future; |
Contributor
There was a problem hiding this comment.
We can't use T here because the compiler doesn't reify it.
Contributor
There was a problem hiding this comment.
oh I guess when it doesn't it just treats it as dynamic though? So it'll do the same thing? Ok.
Member
Author
There was a problem hiding this comment.
Yep. Even though in Dart 1 mode VM pipeline does not reify T it still parses the whole thing correctly and substitutes dynamic here.
Contributor
|
|
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* JSON.decode produces Map<String, dynamic> and List<dynamic> objects. If a more tight type is required then object needs to be converted explicitly (see dart-lang/sdk#31876); * Completer<dynamic> produces Future<dynamic>. In Dart 2 it is runtime error to assign Future<dynamic> to variable of type Future<T>;
This was referenced Dec 3, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Dec 3, 2019
) (#46002) git@github.com:flutter/engine.git/compare/faa11214c09b...1a96087 git log faa1121..1a96087 --first-parent --oneline 2019-12-03 brianosman@google.com Update to newer path fill-type API in Skia (#14070) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objects. If a more tight type is required then object needs to
be converted explicitly (see JSON.decode is not very handy in strong mode dart-lang/sdk#31876);
runtime error to assign Future to variable of type Future;