Skip to content

fix:: elevation and scrollUnderElevation depends on scrolling drawers on issue #120083#150793

Merged
auto-submit[bot] merged 33 commits intoflutter:masterfrom
Mairramer:fix/120083-elevation-drawer-depends-on-scrolling
Aug 29, 2024
Merged

fix:: elevation and scrollUnderElevation depends on scrolling drawers on issue #120083#150793
auto-submit[bot] merged 33 commits intoflutter:masterfrom
Mairramer:fix/120083-elevation-drawer-depends-on-scrolling

Conversation

@Mairramer
Copy link
Copy Markdown
Contributor

@Mairramer Mairramer commented Jun 25, 2024

fixes #120083

Description
This PR addresses the following issues:

  • Resolves the unexpected scrolledUnderElevation trigger that occurs when scrolling within the Drawer and NavigationDrawer.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 25, 2024
@Piinks Piinks self-requested a review June 26, 2024 18:20
@Mairramer Mairramer requested a review from Piinks June 27, 2024 21:18
@Mairramer Mairramer requested a review from Piinks July 3, 2024 12:26
@Mairramer Mairramer requested a review from Piinks July 11, 2024 21:22
Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, I am still not sure this is the best way to resolve this issue. I think I recall @TahaTesser looking at this before. @TahaTesser do you have any thoughts on this? Or insight on your past investigation here?

@TahaTesser
Copy link
Copy Markdown
Contributor

Thank you for the update, I am still not sure this is the best way to resolve this issue. I think I recall @TahaTesser looking at this before. @TahaTesser do you have any thoughts on this? Or insight on your past investigation here?

That's right, I attempted to this in https://github.com/flutter/flutter/pull/122600/files but we had to revert it|

Calling Scaffold.maybeOf to detect drawer and calling findAncestorStateOfType in the scroll notification is too expensive. Not a good idea to look up tree dozens of times as the user scrolls, if i remember correctly.

@Mairramer Mairramer requested a review from Piinks July 13, 2024 14:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
… on issue flutter#120083 (flutter#150793)

fixes flutter#120083

Description
This PR addresses the following issues:
- Resolves the unexpected scrolledUnderElevation trigger that occurs when scrolling within the Drawer and NavigationDrawer.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@Mairramer Mairramer deleted the fix/120083-elevation-drawer-depends-on-scrolling branch January 28, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elevation and scrollUnderElevation depends on scrolling in NavigationDrawer

3 participants