Pass entry points JSON files to front-end server #15180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
approved these changes
Mar 6, 2018
cbracken
approved these changes
Mar 6, 2018
|
|
alexmarkov
added a commit
that referenced
this pull request
Mar 7, 2018
This reverts commit 0edea88.
alexmarkov
added a commit
that referenced
this pull request
Mar 7, 2018
alexmarkov
added a commit
to alexmarkov/flutter
that referenced
this pull request
Mar 7, 2018
alexmarkov
added a commit
that referenced
this pull request
Mar 7, 2018
* Pass entry points JSON files to front-end server (#15180) * Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
) * Revert "Pass entry points JSON files to front-end server (flutter#15180)" This reverts commit 0edea88. Reason: buildbot failures on Mac.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Pass entry points JSON files to front-end server (flutter#15180) * Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation to enable new global type flow analysis in Dart 2 AOT. Global analysis needs entry points JSON files in order to enumerate Dart entry points.
These entry points JSON files are generated while building Flutter engine (flutter/engine#4725, flutter/engine#4734) and uploaded into the cloud as a part of platform/mode-specific artifacts (https://chromium-review.googlesource.com/c/chromium/tools/build/+/944519).
This change adds artifact declarations for entry points JSON files into Flutter tools and passes them to Dart 2 front-end server (which passes them to the global type flow analysis).