Pass entry points JSON files to front-end server, take 2 #15227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try points files and disable AOT transformations in this mode
aam
approved these changes
Mar 7, 2018
|
/cc @keertip these changes should be made to our Bazel rules inside Google. @alexmarkov can you sync with @keertip on the changes? |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Pass entry points JSON files to front-end server (flutter#15180) * Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-landing c41bee6 with fix for ios/debug mode.
Apparently, ios/debug mode also uses 'flutter build aot'. To distinguish this mode from real AOT, extra 'interpreter' flag is passed. In such mode, entry points JSON files should not be used (as they are not included into ios/debug engine artifacts).
Also, this PR disables AOT-specific transformations in the 'interpreter' (ios/debug) mode.