fixed issue to where screen reader reads all buttons when opening datepicker

[DBowen33]

removed container=true property from Semantics wrapper of datepicker dialog. This prevents the screen reader from reading every button in the datepicker dialog whenever a user opens it, reducing SR noise.

Before: https://screencast.googleplex.com/cast/Njc0Mzc1MDA5MTk5NzE4NHw2NTU5ODI4YS0xNA
After: https://screencast.googleplex.com/cast/NTYxMDUwOTIxMzYzMDQ2NHxjOWQ2M2YzNy1hYQ

fixes b/345297872

NOTE: Please let me know if a test is needed for this, since it is only deleting code.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[hannah-hyj]

Yes a PR like this need a test, because the behavior is changed.

[DBowen33]

Added test

[hannah-hyj]

Removing it will also cause mobile a11y behavior to change. Semantics container here controls if the date picker header is a node in the semantics tree, This line was added in #143117 to solve issue #141992. The date picker header being a node is consistent with native a11y behavior. So I think we should keep the Semantics container for the date picker header.

As for SR, i do agree reading out all buttons is too much, does SR always read out all buttons if they are at the same level?

[DBowen33]

@Hangyujin thank you for the feedback. I went ahead and reverted the change and instead added a container: true to the month toggle section. This solves the behavior of reading all of the interactive elements in the datepicker dialog and instead just reads the heading when user opens datepicker dialog and focus goes on it.

Also added explicitChildNodes: true so that the previous and next buttons don't get grouped into the Semantics node of the month selector toggle button on the top. This prevents the SR from reading out the next and previous buttons when the user is focused on selecting a new day.

Also removed excludeSemantics: true from the datepicker toggle button because I noticed that when user is focused on that button, the Semantics information was not being read out to the user. Not quite sure why that was added on that.

Before: https://screencast.googleplex.com/cast/Njc0Mzc1MDA5MTk5NzE4NHw2NTU5ODI4YS0xNA
After:
Screen recording 2024-08-15 5.24.19 PM.webm

[DBowen33]

I'm also having some trouble creating a test case to reflect these new changes, if you have any ideas on what direction to take for this it would be greatly appreciated! :)

[hannah-hyj]

The new changes looks good to me!

For tests:
You tests already reflect the excludeSemantics changes.

As for container: true , You can either use final SemanticsTester semantics = SemanticsTester(tester); and test the semantics tree changes or use tester.getSemantics() to find a semantics node and test it.

I tried on my mobile phone and from the semantics tree it looks like adding container: true in the date picker Semantics will remove the isFocusable flag in the date picker SemanticsNode. You can add a test to reflect that.