Change flag internalAddSemanticForOnTap default value to true#153193
Change flag internalAddSemanticForOnTap default value to true#153193auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exemption: This PR is a flag value change, tests with flag vaule = true |
|
You will have to add |
|
thanks, will do |
d9b16be to
8ad1767
Compare
…r#153193) This is a follow up on flutter#152526 1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) (flutter#152526 ) 2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens 3. accordingly. g3 fix sent: cl/661353802 3. Send a PR to flip the default value to true. (This PR) 4. Send CLs internally to remove internalAddSemanticForOnTap: true. 5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag. (<----This PR is step 3)
This is a follow up on #152526
(<----This PR is step 3)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.