fix unpack freezing app with animation duration zero by Mairramer · Pull Request #153890 · flutter/flutter

Mairramer · 2024-08-21T22:06:07Z

Fixes #153889 an issue where nodes were being removed incorrectly when using AnimationStyle.noAnimation or the animation duration was zero seconds, which previously caused the application to freeze due to hidden state updates. By skipping the animation and updating active nodes immediately in these cases, we avoid these issues and ensure smooth and accurate management of node states.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/test/widgets/sliver_tree_test.dart

Piinks

LGTM thank you!

auto-submit · 2024-09-03T21:59:41Z

auto label is removed for flutter/flutter/153890, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Piinks · 2024-09-03T22:06:00Z

Ah right, I need a second stamp. I will find another reviewer, sit tight. :)

justinmc

LGTM 👍

justinmc · 2024-09-04T17:22:44Z

packages/flutter/test/widgets/sliver_tree_test.dart

    expect(find.text('Root 3'), findsOneWidget);
  });
+
+  testWidgets('TreeSliverNode should close all children when collapsed when animation is disabled', (WidgetTester tester) async {


I double checked that this fails on master 👍

…/flutter#153890)

…n is zero (#7475) Fixes [#153889 ](flutter/flutter#154292) an issue where nodes were being removed incorrectly when using `AnimationStyle.noAnimation `or the animation duration was zero seconds, which previously caused the erratic behavior due to hidden state updates. Similar to flutter/flutter#153890.

…/flutter#153890)

Roll Flutter from 2e221e7 to 303f222 (77 revisions) flutter/flutter@2e221e7...303f222 2024-09-12 34871572+gmackall@users.noreply.github.com Manual roll to 48ddaf578fb0c8326d5b4b680b0f49ea72e33216 (flutter/flutter#155070) 2024-09-12 reidbaker@google.com Externalize and update onboarding instructions (flutter/flutter#154730) 2024-09-12 andrewrkolos@gmail.com when setting up the log reader for a device during `flutter run`, discard any `RPCError` thrown due to the device being disconnected (flutter/flutter#155049) 2024-09-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "iOS: update provisioning profile for 2024-2025 cert (#155052)" (flutter/flutter#155059) 2024-09-12 chris@bracken.jp iOS: update provisioning profile for 2024-2025 cert (flutter/flutter#155052) 2024-09-11 nate.w5687@gmail.com Factor out `Container` objects (flutter/flutter#153619) 2024-09-11 matanlurey@users.noreply.github.com Move (`dev/tools`), complete v0 of `native_driver` (Android) (flutter/flutter#154843) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ade8ef293bc6 to ee5adf6d2ee1 (2 revisions) (flutter/flutter#155046) 2024-09-11 737941+loic-sharma@users.noreply.github.com Fix `flutter run` on Mac x64 hosts if Swift Package Manager is enabled (flutter/flutter#154645) 2024-09-11 engine-flutter-autoroll@skia.org Roll Packages from bb53e5d to 4c18648 (1 revision) (flutter/flutter#155033) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4eb729b7a5c4 to ade8ef293bc6 (3 revisions) (flutter/flutter#155031) 2024-09-11 34465683+rkishan516@users.noreply.github.com fix: Dropdown menu trying to access highlight element which doesn't exist when search and filters both are enabled (flutter/flutter#151969) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_3_5 to be unflaky (flutter/flutter#154993) 2024-09-11 abnhamoda@gmail.com Add 'direction' allow to 'SegmentedButton' oriented vertically (flutter/flutter#150903) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_5_5 to be unflaky (flutter/flutter#154995) 2024-09-11 chingjun@google.com Update the signature of DDS launcher callback. (flutter/flutter#154949) 2024-09-11 30870216+gaaclarke@users.noreply.github.com Migrate Color.toString() test, improves `equalsIgnoringHashCodes` (flutter/flutter#154934) 2024-09-11 36861262+QuncCccccc@users.noreply.github.com Update material and cupertino localizations (flutter/flutter#154959) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_1_5 to be unflaky (flutter/flutter#154991) 2024-09-11 fluttergithubbot@gmail.com Marks Linux build_tests_2_5 to be unflaky (flutter/flutter#154992) 2024-09-11 111122076+shashwatpathak98@users.noreply.github.com Fix `flutter create` warning regarding Java compatibility (flutter/flutter#152836) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54757dab9462 to 4eb729b7a5c4 (1 revision) (flutter/flutter#155022) 2024-09-11 34871572+gmackall@users.noreply.github.com Fix java version used by `build_aar_module_test` (flutter/flutter#154967) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a14c519ea4f to 54757dab9462 (1 revision) (flutter/flutter#155015) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 35a3171b72c5 to 0a14c519ea4f (1 revision) (flutter/flutter#154984) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from b9c0b96c3316 to 35a3171b72c5 (1 revision) (flutter/flutter#154980) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 52eeea075767 to b9c0b96c3316 (1 revision) (flutter/flutter#154976) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from a26075f9b1e6 to 52eeea075767 (1 revision) (flutter/flutter#154973) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 60c15bc0f40e to a26075f9b1e6 (6 revisions) (flutter/flutter#154969) 2024-09-11 matanlurey@users.noreply.github.com Migrate `apple-mobile-web-*` to `mobile-web-*`. (flutter/flutter#154964) 2024-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a038a6f7099 to 60c15bc0f40e (15 revisions) (flutter/flutter#154960) 2024-09-10 30870216+gaaclarke@users.noreply.github.com Adds dart fixes for Color opacity functions (flutter/flutter#154953) 2024-09-10 codefu@google.com Missing benchmarks for `foundation/all_elements_bench.dart` (flutter/flutter#154954) 2024-09-10 30870216+gaaclarke@users.noreply.github.com Update color assertions (flutter/flutter#154752) 2024-09-10 andrewrkolos@gmail.com handle EAGAIN (macOS) in ErrorHandlingProcessManager (flutter/flutter#154306) 2024-09-10 50643541+Mairramer@users.noreply.github.com fix unpack freezing app with animation duration zero (flutter/flutter#153890) 2024-09-10 matanlurey@users.noreply.github.com Remove last `--disable-dart-dev` in `flutter/flutter`. (flutter/flutter#154948) 2024-09-10 34871572+gmackall@users.noreply.github.com Remove scheduler: luci from new `build_aar_module_test` (flutter/flutter#154945) 2024-09-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#154939) 2024-09-10 36861262+QuncCccccc@users.noreply.github.com `CupertinoSlidingSegmentedControl` update (flutter/flutter#152976) 2024-09-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#154933) 2024-09-10 andrewrkolos@gmail.com fix test `chrome.close can recover if getTab throws a StateError` (flutter/flutter#154889) 2024-09-10 jmccandless@google.com SearchBar context menu (flutter/flutter#154833) 2024-09-10 34871572+gmackall@users.noreply.github.com Fix `flutter build aar` for modules that use a plugin (flutter/flutter#154757) 2024-09-10 engine-flutter-autoroll@skia.org Roll Packages from b4e0fc1 to bb53e5d (4 revisions) (flutter/flutter#154926) 2024-09-10 tessertaha@gmail.com Clean up `SnackBar` inherit theme data test (flutter/flutter#154921) ...

…/flutter#153890)

fix unpack freezing app with no animation

e95462d

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 21, 2024

Merge branch 'master' into fix/treesliver-unpack-with-no-animation

8e81cfc

This was referenced Aug 21, 2024

Fixes TreeSliver collapsing not working #153438

Merged

[two_dimensional_scrollables] Fix TreeView bug when animation duration is zero flutter/packages#7475

Merged

Mairramer changed the title ~~fix unpack freezing app with no animation~~ fix unpack freezing app with animation duration zero Aug 22, 2024

Piinks reviewed Aug 28, 2024

View reviewed changes

packages/flutter/test/widgets/sliver_tree_test.dart Show resolved Hide resolved

Mairramer and others added 2 commits August 28, 2024 14:45

added comment

6faa1c9

Merge branch 'master' into fix/treesliver-unpack-with-no-animation

b517251

Piinks approved these changes Sep 3, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024

justinmc approved these changes Sep 4, 2024

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2024

auto-submit bot merged commit 93d06eb into flutter:master Sep 10, 2024

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to fadbf4447172 (55 revisions) flutter/packages#7623

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

ac663da

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to d565781992f1 (56 revisions) flutter/packages#7624

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

71d4e60

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 0a9148870ad9 (57 revisions) flutter/packages#7625

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

d77891b

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to d8de38f10d56 (59 revisions) flutter/packages#7627

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

e99f454

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to bcf1c5a24358 (60 revisions) flutter/packages#7628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

a6bc9a0

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 6e46ee8d6d6f (63 revisions) flutter/packages#7629

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

f4c6018

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 04e1b174ea6d (66 revisions) flutter/packages#7630

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

6d74eec

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 50a190caec0c (74 revisions) flutter/packages#7634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

cc0df48

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to d8f8613a5b94 (75 revisions) flutter/packages#7635

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

2943c58

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 90aa59f6c32f (76 revisions) flutter/packages#7637

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

73193ba

…/flutter#153890)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 303f222e17e3 (77 revisions) flutter/packages#7638

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

745cffe

…/flutter#153890)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

a2da4d8

…/flutter#153890)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

93d06eb fix unpack freezing app with animation duration zero (flutter…

c9bc831

…/flutter#153890)

Mairramer deleted the fix/treesliver-unpack-with-no-animation branch January 28, 2026 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix unpack freezing app with animation duration zero #153890

fix unpack freezing app with animation duration zero #153890
auto-submit[bot] merged 4 commits intoflutter:masterfrom
Mairramer:fix/treesliver-unpack-with-no-animation

Mairramer commented Aug 21, 2024

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

auto-submit bot commented Sep 3, 2024

Uh oh!

Piinks commented Sep 3, 2024

Uh oh!

justinmc left a comment

Uh oh!

justinmc Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Mairramer commented Aug 21, 2024

Pre-launch Checklist

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 3, 2024

Uh oh!

Piinks commented Sep 3, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants