Update the web test suite runner to use the correct flutter_driver output path if FLUTTER_TEST_OUTPUTS_DIR is set#153966
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Aug 22, 2024
Conversation
…tput path if FLUTTER_TEST_OUTPUTS_DIR is set A pending change to the flutter_drone LUCI recipe is using a logging library that sets the FLUTTER_TEST_OUTPUTS_DIR environment variable (see https://flutter.googlesource.com/recipes/+/b111cd3ef2297e66905cc48c2cfedce0cf1ba46f) flutter_driver uses FLUTTER_TEST_OUTPUTS_DIR as its output directory if it is set. run_web_tests invokes flutter_driver and needs to look for outputs in that directory.
matanlurey
approved these changes
Aug 22, 2024
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/153966, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 24, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 24, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…tput path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter#153966) A pending change to the flutter_drone LUCI recipe is using a logging library that sets the FLUTTER_TEST_OUTPUTS_DIR environment variable (see https://flutter.googlesource.com/recipes/+/b111cd3ef2297e66905cc48c2cfedce0cf1ba46f) flutter_driver uses FLUTTER_TEST_OUTPUTS_DIR as its output directory if it is set. run_web_tests invokes flutter_driver and needs to look for outputs in that directory.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…river output path if FLUTTER_TEST_OUTPUTS_DIR is set (flutter/flutter#153966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pending change to the flutter_drone LUCI recipe is using a logging library that sets the FLUTTER_TEST_OUTPUTS_DIR environment variable (see https://flutter.googlesource.com/recipes/+/b111cd3ef2297e66905cc48c2cfedce0cf1ba46f)
flutter_driver uses FLUTTER_TEST_OUTPUTS_DIR as its output directory if it is set. run_web_tests invokes flutter_driver and needs to look for outputs in that directory.