Skip to content

[Windows] Improve symlink ERROR_ACCESS_DENIED error message#154030

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
loic-sharma:windows_symlink_error
Aug 26, 2024
Merged

[Windows] Improve symlink ERROR_ACCESS_DENIED error message#154030
auto-submit[bot] merged 1 commit intoflutter:masterfrom
loic-sharma:windows_symlink_error

Conversation

@loic-sharma
Copy link
Copy Markdown
Member

@loic-sharma loic-sharma commented Aug 23, 2024 •
edited
Loading

Currently, if creating a symlink on Windows fails due to ERROR_ACCESS_DENIED, you'll get an error message like:

Error: ERROR_ACCESS_DENIED file system exception thrown while trying to create a symlink from source to dest

The source and dest paths are incorrect.

This will help us debug: #153758

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 23, 2024
@loic-sharma loic-sharma changed the title [Windows] Fix symlink ERROR_ACCESS_DENIED error message [Windows] Improve symlink ERROR_ACCESS_DENIED error message Aug 23, 2024
andrewkolos
andrewkolos approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit ebfaa45 into flutter:master Aug 26, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
b49a95d 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
c3ac5b6 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
bcf9b70 
…lutter/flutter#154030)
@loic-sharma loic-sharma mentioned this pull request Aug 26, 2024
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
4840aec 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
f859c49 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
defb4cb 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
8c456d2 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
bcc3ceb 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
78c2a1f 
…lutter/flutter#154030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
c6d127d 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
5e917c1 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
5020d8f 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
3a7172e 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
384e3d5 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
96ef910 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
fd8ce82 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
f71e507 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
fe0e8bd 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
9caa3f1 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
117e19e 
…lutter/flutter#154030)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@loic-sharma @Buchimi
[Windows] Improve symlink ERROR_ACCESS_DENIED error message (flutter#…
72b4eb1 
…154030)

Currently, if creating a symlink on Windows fails due to `ERROR_ACCESS_DENIED`, you'll get an error message like:

```
Error: ERROR_ACCESS_DENIED file system exception thrown while trying to create a symlink from source to dest
```

The `source` and `dest` paths are incorrect.

This will help us debug: flutter#153758
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
32e5752 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
d4c5377 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
4132c5e 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
dd92c95 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
631a3dc 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
65fd309 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
1465584 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
0af1afa 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
f7ae96d 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
3d8dc6b 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
23014fd 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
f4b9f41 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
492630e 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
303c819 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
bad21d1 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
25a8716 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
0838c12 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
6aa986c 
…lutter/flutter#154030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
ebfaa45 [Windows] Improve symlink ERROR_ACCESS_DENIED error message (f…
79fd9db 
…lutter/flutter#154030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@andrewkolos andrewkolos andrewkolos approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loic-sharma @cbracken @andrewkolos