Skip to content

doc: fix typo in testing doc#154105

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Lxxyx:doc/typo
Aug 26, 2024
Merged

doc: fix typo in testing doc#154105
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Lxxyx:doc/typo

Conversation

@Lxxyx
Copy link
Copy Markdown
Contributor

@Lxxyx Lxxyx commented Aug 26, 2024

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Detail

The correct parameter is --web-port, not --webport

@github-actions github-actions bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Aug 26, 2024
goderbauer
goderbauer approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer requested a review from Piinks August 26, 2024 16:47
Piinks
Piinks approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit 602f9af into flutter:master Aug 26, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
7bb5c18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
e86dc0d
@Lxxyx Lxxyx deleted the doc/typo branch August 27, 2024 03:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
3e9b47a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
cad065b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
a0c53e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
de681d5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
48a5cc5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
174c0cf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
708d88c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
3e299b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
62bdab6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
5f5310a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
e134638
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
b15c91b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
b7dd081
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
8cb9398
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
83b615a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
788a060
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
f714a2a
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@Lxxyx @Buchimi
doc: fix typo in testing doc (flutter#154105)
9761411 
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

- [] I listed at least one issue that this PR fixes in the description above.
- [] I added new tests to check the change I am making, or this PR is [test-exempt].
- [] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
- [] All existing and new tests are passing.

## Detail
The correct parameter is --web-port, not --webport
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
20be5db
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
f195fbd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
a397273
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
7a9ca7d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
7b9fa84
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
940d7d0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
9c0ee87
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
a77f73b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
33b9787
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
494e76a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
08ee9c3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
d173489
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
b97c951
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
2130bc6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
aa7fe38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
c057bcd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
30f9be9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
dee21ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
602f9af doc: fix typo in testing doc (flutter/flutter#154105)
c6e260e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lxxyx @goderbauer @Piinks