Skip to content

Add warning if changing flutterEmbedding string.#154181

Merged
auto-submit[bot] merged 3 commits intomasterfrom
d-flutter-embedding-warning
Aug 28, 2024
Merged

Add warning if changing flutterEmbedding string.#154181
auto-submit[bot] merged 3 commits intomasterfrom
d-flutter-embedding-warning

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

@reidbaker reidbaker commented Aug 27, 2024

No bug

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from a team August 27, 2024 15:10
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 27, 2024
@reidbaker reidbaker requested a review from chunhtai August 27, 2024 15:10
chunhtai
chunhtai approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker self-assigned this Aug 27, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2024
@reidbaker reidbaker removed their assignment Aug 27, 2024
johnmccutchan
johnmccutchan reviewed Aug 27, 2024
View reviewed changes
packages/flutter_tools/lib/src/project.dart Outdated
// External code checks for this string to indentify flutter android apps.
// See https://critique.corp.google.com/cl/667760684 as an example.
// External code checks for this string to indentify flutter android apps.
// See https://critique.corp.google.com/cl/667760684 as an example.
Copy link
Copy Markdown
Contributor

@johnmccutchan johnmccutchan Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace this with just "cl/6677..." ? That is drop the full domain name.

Copy link
Copy Markdown
Contributor Author

@reidbaker reidbaker Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2024
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit bot commented Aug 27, 2024

auto label is removed for flutter/flutter/154181, due to - The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit bot commented Aug 28, 2024

auto label is removed for flutter/flutter/154181, due to - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker
Copy link
Copy Markdown
Contributor Author

reidbaker commented Aug 28, 2024 •
edited
Loading

I am debating merging on red and ignoring "customer linux customer testing" because this pr adds a comment to android code by definition it can't impact customer code.

WIll try a 4th rerun and then merge.

https://discord.com/channels/608014603317936148/608020180177780791/1278379589638422538

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit auto-submit bot merged commit 75190cb into master Aug 28, 2024
@auto-submit auto-submit bot deleted the d-flutter-embedding-warning branch August 28, 2024 16:15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
ad968bc 
…tter#154181)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
be72c97 
…tter#154181)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
456abf0 
…tter#154181)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
e16a4a9 
…tter#154181)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 28, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
38c383e 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
bec4539 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
030d4e4 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
7f31d32 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
7fda52f 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
1dc6c41 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
ab2e376 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
7ace31f 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
791ee51 
…tter#154181)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@reidbaker @Buchimi
Add warning if changing flutterEmbedding string. (flutter#154181)
0914019 
No bug
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
7837644 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
6e77e31 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
03d1c5f 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
04e17c1 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
3028ddf 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
7ca54ac 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
dac7c8a 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
25067bb 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
ef03a5b 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
b075f66 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
d9e05ab 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
bc847ad 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
f1f8034 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
9bc7eeb 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
3edcdaf 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
b2849bf 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
7adb49a 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
0209a13 
…tter#154181)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
75190cb Add warning if changing flutterEmbedding string. (flutter/flu…
1caee5a 
…tter#154181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnmccutchan johnmccutchan johnmccutchan left review comments

@gmackall gmackall gmackall approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidbaker @johnmccutchan @gmackall @chunhtai