Skip to content

Defer overlay child layout if the target overlay is currently laying out its size-determining child#154222

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
LongCatIsLooong:overlay-portal-unbounded-constraints-fix
Aug 29, 2024
Merged

Defer overlay child layout if the target overlay is currently laying out its size-determining child#154222
auto-submit[bot] merged 3 commits intoflutter:masterfrom
LongCatIsLooong:overlay-portal-unbounded-constraints-fix

Conversation

@LongCatIsLooong
Copy link
Copy Markdown
Contributor

@LongCatIsLooong LongCatIsLooong commented Aug 28, 2024

Fixes #153903

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong
Fixes flutter#153903
fc44329 
Defer overlay child layout if the target overlay is currently laying out
its size-determining child
@LongCatIsLooong
comment
29da55f
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 28, 2024
goderbauer
goderbauer approved these changes Aug 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit bot commented Aug 28, 2024

auto label is removed for flutter/flutter/154222, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2024
@auto-submit auto-submit bot merged commit 24194e5 into flutter:master Aug 29, 2024
@LongCatIsLooong LongCatIsLooong deleted the overlay-portal-unbounded-constraints-fix branch August 29, 2024 02:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
637b845 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
887e380 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
560dd2b 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
b78a1c6 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
11268f7 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
9dea606 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
6fdb590 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
854f40e 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
493557f 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
84a2fb5 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
e3a489c 
… laying out its size-determining child (flutter/flutter#154222)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
9412754 
… laying out its size-determining child (flutter/flutter#154222)
@Piinks Piinks mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
9763ed6 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
e448a4c 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
86b6a78 
… laying out its size-determining child (flutter/flutter#154222)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@LongCatIsLooong @Buchimi
Defer overlay child layout if the target overlay is currently laying …
5a22889 
…out its size-determining child (flutter#154222)

Fixes flutter#153903
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
bf2a692 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
0c615fb 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
5c691c1 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
21c0512 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
0244f8a 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
e152633 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
a531e52 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
eae8f35 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
d7f6f9e 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
ff6d4bc 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
6fac6f1 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
974e2f3 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
3ba0da0 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
dc44bb5 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
51ea530 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
029704c 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
88432e4 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
77213d2 
… laying out its size-determining child (flutter/flutter#154222)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
24194e5 Defer overlay child layout if the target overlay is currently…
c1b7763 
… laying out its size-determining child (flutter/flutter#154222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Menu Anchor sometimes throws a constraints error.

2 participants

@LongCatIsLooong @goderbauer