Replace `ListTile` usage with `CupertinoListTile` by ishon19 · Pull Request #154473 · flutter/flutter

ishon19 · 2024-08-31T13:44:12Z

This PR replaces the ListTile usage in the cupertino switch example with CupertinoListTile.

Fixes #154450

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

piedcipher

LGTM, thanks for cleaning up

ishon19 · 2024-08-31T17:03:13Z

LGTM, thanks for cleaning up

Of course! thanks for the review @piedcipher

packages/flutter/test/cupertino/switch_test.dart

victorsanni

LGTM and thanks for the change!

ishon19 · 2024-09-03T18:17:27Z

LGTM and thanks for the change!

Thanks for the review @victorsanni!

…utter#154473)

ishon19 added 2 commits August 31, 2024 09:30

refactor: replace listTile usage with CupertinoListTile

9bbbd66

fix: test

60e795c

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 31, 2024

piedcipher approved these changes Aug 31, 2024

View reviewed changes

piedcipher requested changes Sep 2, 2024

View reviewed changes

packages/flutter/test/cupertino/switch_test.dart Outdated Show resolved Hide resolved

test: revert change

8612255

ishon19 requested a review from piedcipher September 2, 2024 21:23

piedcipher approved these changes Sep 3, 2024

View reviewed changes

piedcipher requested a review from victorsanni September 3, 2024 09:18

victorsanni approved these changes Sep 3, 2024

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024

auto-submit bot merged commit 6f19403 into flutter:master Sep 3, 2024

engine-flutter-autoroll mentioned this pull request Sep 3, 2024

Roll Flutter from b8f89f70bf4e to 6f19403eb6eb (159 revisions) flutter/packages#7570

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

04a37e4

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 3, 2024

Roll Flutter from b8f89f70bf4e to 28a912430499 (162 revisions) flutter/packages#7572

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

81351e7

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to a5ca16ea9404 (185 revisions) flutter/packages#7576

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

5589c74

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 4a54ca828583 (186 revisions) flutter/packages#7577

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

33cc859

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 40f763aeaa0b (187 revisions) flutter/packages#7579

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

f61bc8f

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 056c40f55b2c (188 revisions) flutter/packages#7580

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

4da89ed

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to d9dda9d08fc3 (189 revisions) flutter/packages#7581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

8835cd6

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 4e8df8be3148 (192 revisions) flutter/packages#7582

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

739b3b5

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to a7cd788d80cc (201 revisions) flutter/packages#7584

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

594205b

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to 45ef8f36ff41 (202 revisions) flutter/packages#7585

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

fa9c595

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to a3301cecae28 (203 revisions) flutter/packages#7588

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

af67274

…utter#154473)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to 834566f05d36 (204 revisions) flutter/packages#7589

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

2779500

…utter#154473)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

836adda

…utter#154473)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

01885c7

…utter#154473)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

6f19403 Replace ListTile usage with CupertinoListTile (flutter/fl…

0c1edb5

…utter#154473)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `ListTile` usage with `CupertinoListTile`#154473

Replace `ListTile` usage with `CupertinoListTile`#154473
auto-submit[bot] merged 3 commits intoflutter:masterfrom
shashwatpathak98:154450-replace-listtile-with-cupertinolisttile

ishon19 commented Aug 31, 2024

Uh oh!

piedcipher left a comment

Uh oh!

ishon19 commented Aug 31, 2024

Uh oh!

Uh oh!

victorsanni left a comment

Uh oh!

ishon19 commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ishon19 commented Aug 31, 2024

Pre-launch Checklist

Uh oh!

piedcipher left a comment

Choose a reason for hiding this comment

Uh oh!

ishon19 commented Aug 31, 2024

Uh oh!

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

ishon19 commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants