Skip to content

[CP] Disable Vulkan on MediaTek SoC. #164495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2025
Merged

[CP] Disable Vulkan on MediaTek SoC. #164495

merged 6 commits into from
Mar 13, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 3, 2025

Cherry pick of #164126

Jonah Williams added 2 commits March 3, 2025 10:04
[Impeller] detect mediatek soc and fall back to GLES. (flutter#164126)
c8bd4f9 
If the device is _probably_ mediatek, then use OpenGL. We may relax this
check if the future if we find a mediatek soc that works well w/ Vulkan.
update changelog.
e06266b
@jonahwilliams jonahwilliams marked this pull request as ready for review March 3, 2025 18:08
@jonahwilliams jonahwilliams requested a review from jtmcdole March 3, 2025 18:08
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Mar 3, 2025
@jonahwilliams jonahwilliams added cp: stable cherry pick this pull request to stable release candidate branch cp: review Cherry-picks in the review queue and removed platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Mar 3, 2025
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Mar 6, 2025
camsim99
camsim99 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the cp: approved Approved cherry-pick request label Mar 6, 2025
reidbaker
reidbaker requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, looking for a test and changelog.

Will also take a @jtmcdole override that a test is required or cherry picking.

reidbaker
reidbaker approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediaTek soc is tested using device from the testlab.

@reidbaker
Copy link
Contributor

reidbaker commented Mar 11, 2025

@jonahwilliams can you resolve the conflict in flutter_main.cc code.

Jonah Williams and others added 2 commits March 12, 2025 22:03
@reidbaker
Update CHANGELOG.md
f9dbe20 
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
Merge branch 'flutter-3.29-candidate.0' into disable_mediatek
05a9c70
@github-actions github-actions bot removed platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Mar 13, 2025
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot merged commit 18b71d6 into flutter:flutter-3.29-candidate.0 Mar 13, 2025
150 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
18b71d647 [CP] Disable Vulkan on MediaTek SoC. (flutter/flutter#164495)
27dca62
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
18b71d647 [CP] Disable Vulkan on MediaTek SoC. (flutter/flutter#164495)
5df34ca
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
18b71d647 [CP] Disable Vulkan on MediaTek SoC. (flutter/flutter#164495)
a71b0b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
18b71d647 [CP] Disable Vulkan on MediaTek SoC. (flutter/flutter#164495)
ff89aad
@WyvernPirate WyvernPirate mentioned this pull request Apr 3, 2025
Merged
@reidbaker reidbaker mentioned this pull request Apr 4, 2025
Merged
9 tasks
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@Fintasys
[CP] Disable Vulkan on MediaTek SoC. (flutter#164495)
ab035a0 
Cherry pick of flutter#164126
@KashyapBhat
Copy link

KashyapBhat commented May 28, 2025

Which version & channel will I find the fix? Please help.

@reidbaker
Copy link
Contributor

reidbaker commented May 28, 2025

This issue has been fixed by in this pull request. To determine what versions of Flutter contain the fix, please see where’s my commit. If the commit has no release tag, it is currently only available in the master channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

@camsim99 camsim99 camsim99 approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonahwilliams @reidbaker @KashyapBhat @jtmcdole @camsim99