Skip to content

Have flutter create create a pubspec.lock to ensure pinned versions are being used.#175352

Merged
auto-submit[bot] merged 10 commits into
flutter:masterfrom
sigurdm:create_create_lockfile
Apr 7, 2026
Merged

Have flutter create create a pubspec.lock to ensure pinned versions are being used.#175352
auto-submit[bot] merged 10 commits into
flutter:masterfrom
sigurdm:create_create_lockfile

Conversation

@sigurdm
Copy link
Copy Markdown
Contributor

@sigurdm sigurdm commented Sep 15, 2025

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 15, 2025
@Piinks
Copy link
Copy Markdown
Contributor

Piinks commented Dec 1, 2025

Greetings from stale PR triage! 👋
Is this change still on your radar?

@sigurdm
Copy link
Copy Markdown
Contributor Author

sigurdm commented Dec 2, 2025

Yes it is - but we are still not exactly decided if this is what we are going to do.

@sigurdm sigurdm marked this pull request as ready for review March 10, 2026 14:40
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the flutter create command to generate a pubspec.lock file with pinned versions for certain dependencies. This is achieved by adding a _generatePubspecLock function that reads the pubspec.lock from the Flutter SDK root and creates a new pubspec.lock in the generated project with a subset of dependencies. A new test is also added to verify this functionality.

Comment thread packages/flutter_tools/lib/src/commands/create.dart Outdated
@sigurdm sigurdm added the CICD Run CI/CD label Mar 13, 2026
Comment thread packages/flutter_tools/lib/src/commands/create.dart Outdated
Comment thread packages/flutter_tools/lib/src/commands/create.dart Outdated
Comment thread packages/flutter_tools/lib/src/commands/create.dart
@github-actions github-actions Bot removed the CICD Run CI/CD label Mar 17, 2026
@sigurdm sigurdm requested a review from stuartmorgan-g March 19, 2026 12:51
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 3, 2026
@sigurdm sigurdm added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 7, 2026
Merged via the queue into flutter:master with commit 941e3f3 Apr 7, 2026
142 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 7, 2026
flutter/flutter@9cd60b5...a0924c7

2026-04-07 dacoharkes@google.com Reland "[data_assets] Cleanup tests" (flutter/flutter#184714)
2026-04-07 matt.kosarek@canonical.com Use the WindowRegistry in the multiple_windows example app (flutter/flutter#184579)
2026-04-07 15619084+vashworth@users.noreply.github.com Introduce command to build a swift package for SwiftPM add to app integration (flutter/flutter#184660)
2026-04-07 sigurdm@google.com Have `flutter create` create a pubspec.lock to ensure pinned versions are being used. (flutter/flutter#175352)
2026-04-07 59215665+davidhicks980@users.noreply.github.com [widgets/raw_menu_anchor.dart] Always call onClose and onCloseRequested on descendants before parent. (flutter/flutter#182357)
2026-04-07 rmolivares@renzo-olivares.dev `WindowsPlugin` should not crash when ffiPlugin enabled (flutter/flutter#184695)
2026-04-06 97480502+b-luk@users.noreply.github.com Use full goto.google.com hostname for go/ links (flutter/flutter#184679)
2026-04-06 34871572+gmackall@users.noreply.github.com Apply rect clipping to surface views (flutter/flutter#184471)
2026-04-06 jhy03261997@gmail.com [A11y] Allow percentage strings like "50%" as `SemanticsValue` for `ProgressIndicator` (flutter/flutter#183670)
2026-04-06 louisehsu@google.com Fix invisible accessibility element before scroll view (flutter/flutter#184155)
2026-04-06 engine-flutter-autoroll@skia.org Roll Skia from 163dfdf500c7 to e264d870a380 (2 revisions) (flutter/flutter#184674)
2026-04-06 54688429+TrangLeQuynh@users.noreply.github.com Keep last character obscured when toggling obscureText (flutter/flutter#183488)
2026-04-06 15619084+vashworth@users.noreply.github.com Parse scheme file with XML parser for SwiftPM migrator (flutter/flutter#184525)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
… are being used. (flutter#175352)

Part of https://flutter.dev/go/unpin-flutter-sdk-dependencies
Preparing for flutter#158050

---------

Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants