Skip to content

New#175978

Closed
AuraAi-vet wants to merge 7 commits intoflutter:masterfrom
AuraAi-vet:master
Closed

New#175978
AuraAi-vet wants to merge 7 commits intoflutter:masterfrom
AuraAi-vet:master

Conversation

@AuraAi-vet
Copy link
Copy Markdown

@AuraAi-vet AuraAi-vet commented Sep 25, 2025

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Sep 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new VS Code settings for Dart and Flutter development into the workspace configuration. While most of these settings enhance the development experience, there is a critical inconsistency in the line length configuration. The new settings specify a line length of 80 characters, which conflicts with the project's analysis_options.yaml that defines a page_width of 100. This discrepancy will lead to inconsistent formatting across the team and should be rectified.

Comment on lines +9 to +10
"dart.lineLength": 80,
"editor.rulers": [80],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is an inconsistency between the line length defined here and the project's established formatting rules. This file sets dart.lineLength and editor.rulers to 80, but the analysis_options.yaml file specifies page_width: 100. To ensure consistent formatting for all contributors, whether they use VS Code's format-on-save or the command-line dart format tool, these values should match the project-wide configuration.

Suggested change
"dart.lineLength": 80,
"editor.rulers": [80],
"dart.lineLength": 100,
"editor.rulers": [100],

@tirth-patel-nc tirth-patel-nc added the r: invalid Issue is closed as not valid label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r: invalid Issue is closed as not valid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants