Skip to content

Conversation

@mraleph
Copy link
Member

@mraleph mraleph commented Oct 17, 2025

Make the code for updating Dart dependencies easier to follow by
splitting the logic into helper functions, adding comments and
tweaking logic slightly.

Make it handle all *_git variables uniformly instead of
hardcoding specific ones.

Make it handle the case where *_git variable does not exist
without emitting incorrect result.

Add a unit test to make it simpler to check that script does
reasonable things for all different inputs.

Make the code for updating Dart dependencies easier to follow by
splitting the logic into helper functions, adding comments and
tweaking logic slightly.

Make it handle all *_git variables uniformly instead of
hardcoding specific ones.

Make it handle the case where *_git variable does not exist
without emitting incorrect result.

Add a unit test to make it simpler to check that script does
reasonable things for all different inputs.
@mraleph mraleph requested a review from jason-simmons October 17, 2025 12:17
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Oct 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a significant cleanup to the create_updated_flutter_deps.py script. By refactoring complex logic into well-documented helper functions (PrettifySourcePathForDEPS and ComputeDartDeps), the code is now much more readable and maintainable. The changes also improve the handling of *_git variables and add a comprehensive suite of unit tests, which is an excellent practice for ensuring the script's reliability. Overall, this is a high-quality refactoring. I have a couple of minor suggestions to further enhance code clarity.

@mraleph mraleph added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2025

autosubmit label was removed for flutter/flutter/177162, because - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2025
@mraleph mraleph added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Oct 20, 2025
Merged via the queue into flutter:master with commit 2d34167 Oct 20, 2025
186 of 187 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 20, 2025
flutter/flutter@891d7d5...2d34167

2025-10-20 vegorov@google.com Cleanup create_updated_flutter_deps.py a bit (flutter/flutter#177162)
2025-10-20 jessy.yameogo@gmail.com Fixed hot reload/restart crashes after closing browser tab on web-server device (flutter/flutter#177026)
2025-10-20 engine-flutter-autoroll@skia.org Roll Skia from 0a3ace6fde82 to ed4294faecde (2 revisions) (flutter/flutter#177249)
2025-10-20 bruno.leroux@gmail.com Add DropdownMenu.decorationBuilder (flutter/flutter#176264)
2025-10-20 engine-flutter-autoroll@skia.org Roll Skia from 05e2f42f533d to 0a3ace6fde82 (1 revision) (flutter/flutter#177242)
2025-10-20 engine-flutter-autoroll@skia.org Roll Skia from 89abc5393317 to 05e2f42f533d (1 revision) (flutter/flutter#177238)
2025-10-20 koji.wakamiya@gmail.com [ios][engine] Fix autofill context cleanup and view lifecycle management (flutter/flutter#173598)
2025-10-20 rajveer0malviya@gmail.com Fix Image.network not using cache when headers are specified (flutter/flutter#176831)
2025-10-19 engine-flutter-autoroll@skia.org Roll Dart SDK from a66f334fee2a to 2cd2106f2cef (4 revisions) (flutter/flutter#177190)
2025-10-19 engine-flutter-autoroll@skia.org Roll Skia from 2d424175a481 to 89abc5393317 (1 revision) (flutter/flutter#177235)
2025-10-19 ahmedsameha1@gmail.com Make sure that a ListTile doesn't crash in 0x0 environment (flutter/flutter#176176)
2025-10-19 ahmedsameha1@gmail.com Make sure that a DropdownButton doesn't crash in 0x0 environment (flutter/flutter#174880)
2025-10-19 engine-flutter-autoroll@skia.org Roll Skia from 899155871d29 to 2d424175a481 (1 revision) (flutter/flutter#177229)
2025-10-19 engine-flutter-autoroll@skia.org Roll Skia from b864c56efb66 to 899155871d29 (1 revision) (flutter/flutter#177227)
2025-10-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from M8WT2GMY46e_0fFho... to tKrvmvTOQITL81oOC... (flutter/flutter#177223)
2025-10-19 engine-flutter-autoroll@skia.org Roll Skia from 0992b560454f to b864c56efb66 (1 revision) (flutter/flutter#177222)
2025-10-18 matt.boetger@gmail.com Fix HEIF decoding (flutter/flutter#176860)
2025-10-18 engine-flutter-autoroll@skia.org Roll Skia from 74df18176924 to 0992b560454f (1 revision) (flutter/flutter#177217)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants