Skip to content

Use SkPathBuilder with SkPathMeasure::getSegment#181205

Merged
Rusino merged 1 commit into
flutter:masterfrom
bungeman:mutable_patheffect
Jan 21, 2026
Merged

Use SkPathBuilder with SkPathMeasure::getSegment#181205
Rusino merged 1 commit into
flutter:masterfrom
bungeman:mutable_patheffect

Conversation

@bungeman
Copy link
Copy Markdown
Contributor

Migrate calls from the now deprecated SkPathMeasure::getSegment which took SkPath to the new version of SkPathMeasure::getSegment which takes SkPathBuilder.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jan 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the usage of SkPathMeasure::getSegment to use the new API which accepts an SkPathBuilder instead of an SkPath. The change correctly replaces SkPath with SkPathBuilder and uses dst.detach() to obtain the SkPath for creating the CanvasPath. The implementation is correct and aligns with the described API migration. I have no further comments.

Migrate calls from the now deprecated SkPathMeasure::getSegment which
took SkPath to the new version of SkPathMeasure::getSegment which takes
SkPathBuilder.
@Rusino Rusino added this pull request to the merge queue Jan 21, 2026
Merged via the queue into flutter:master with commit 9c66d26 Jan 21, 2026
177 of 179 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@jtmcdole
Copy link
Copy Markdown
Member

This PR was added to the merge queue while the tree was red. Was there a reason for this?

@Rusino
Copy link
Copy Markdown
Contributor

Rusino commented Jan 21, 2026 via email

@jtmcdole
Copy link
Copy Markdown
Member

No - authors with "write" permission can submit to the merge queue even if the tree is red. We prefer to use the autosubmit label which would block and wait (unless the emergency label was active).

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
Migrate calls from the now deprecated SkPathMeasure::getSegment which
took SkPath to the new version of SkPathMeasure::getSegment which takes
SkPathBuilder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants