Use SkPathBuilder with SkPathMeasure::getSegment#181205
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request migrates the usage of SkPathMeasure::getSegment to use the new API which accepts an SkPathBuilder instead of an SkPath. The change correctly replaces SkPath with SkPathBuilder and uses dst.detach() to obtain the SkPath for creating the CanvasPath. The implementation is correct and aligns with the described API migration. I have no further comments.
f73e2f8 to
13cacd4
Compare
Migrate calls from the now deprecated SkPathMeasure::getSegment which took SkPath to the new version of SkPathMeasure::getSegment which takes SkPathBuilder.
13cacd4 to
ca038e9
Compare
|
This PR was added to the merge queue while the tree was red. Was there a reason for this? |
|
I assumed that it will be submitted AFTER the queue is green. Is it wrong?
…On Wed, Jan 21, 2026 at 11:53 AM jtmcdole ***@***.***> wrote:
*jtmcdole* left a comment (flutter/flutter#181205)
<#181205 (comment)>
This PR was added to the merge queue while the tree was red. Was there a
reason for this?
—
Reply to this email directly, view it on GitHub
<#181205 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFWYHL4BNAL6SZA4ZOQVS34H6VKHAVCNFSM6AAAAACSKBOWLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZZGYZTONZSGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
No - authors with "write" permission can submit to the merge queue even if the tree is red. We prefer to use the |
Migrate calls from the now deprecated SkPathMeasure::getSegment which took SkPath to the new version of SkPathMeasure::getSegment which takes SkPathBuilder.
Migrate calls from the now deprecated SkPathMeasure::getSegment which took SkPath to the new version of SkPathMeasure::getSegment which takes SkPathBuilder.