Skip to content

Conversation

@reidbaker
Copy link
Contributor

  • Add changlog entry for 3.38.8

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@fluttergithubbot
Copy link
Contributor

An existing Git SHA, 98a6d3ec7186cdc659f14dd7fc90cc7153f0de26, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a changelog entry for the 3.38.8 hotfix. The review found a minor formatting issue in CHANGELOG.md where the new version header uses an incorrect markdown level. A suggestion has been provided to fix this for consistency with the rest of the file.

CHANGELOG.md Outdated

## Flutter 3.38 Changes

## [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The markdown header for the new version should be level 3 (###) to maintain consistency with other hotfix entries in this file. The current level 2 (##) is typically used for major version change sections (e.g., ## Flutter 3.38 Changes).

Suggested change
## [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8)
### [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually correctly called out.

Updated changelog to clarify crash behavior for chrome.
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2026
@auto-submit auto-submit bot merged commit 6ae02d4 into flutter:flutter-3.38-candidate.0 Jan 23, 2026
5 checks passed
@reidbaker reidbaker mentioned this pull request Jan 26, 2026
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants