-
Notifications
You must be signed in to change notification settings - Fork 29.9k
Add changlog entry for 3.38.8 #181407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changlog entry for 3.38.8 #181407
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a changelog entry for the 3.38.8 hotfix. The review found a minor formatting issue in CHANGELOG.md where the new version header uses an incorrect markdown level. A suggestion has been provided to fix this for consistency with the rest of the file.
CHANGELOG.md
Outdated
|
|
||
| ## Flutter 3.38 Changes | ||
|
|
||
| ## [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown header for the new version should be level 3 (###) to maintain consistency with other hotfix entries in this file. The current level 2 (##) is typically used for major version change sections (e.g., ## Flutter 3.38 Changes).
| ## [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8) | |
| ### [3.38.8](https://github.com/flutter/flutter/releases/tag/3.38.8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually correctly called out.
Updated changelog to clarify crash behavior for chrome.
6ae02d4
into
flutter:flutter-3.38-candidate.0
Pre-launch Checklist
///).