Skip to content

Add missing dependencies to framework_tests_misc_leak_tracking#181929

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
dkwingsmt:misc-leak-dependency
Feb 10, 2026
Merged

Add missing dependencies to framework_tests_misc_leak_tracking#181929
auto-submit[bot] merged 2 commits intoflutter:masterfrom
dkwingsmt:misc-leak-dependency

Conversation

@dkwingsmt
Copy link
Copy Markdown
Contributor

This PR adds more dependencies to the CI task framework_tests_misc_leak_tracking so that it has the same dependencies as framework_tests_misc.

This is to fix a consistent failure currently in the framework_tests_misc_leak_tracking task about missing Android SDK:

00:00 +7: test\adb_test.dart: device adb startLoggingToSink calls adb
00:00 +7 -1: test\framework\browser_test.dart: BlinkTraceEvent works with Chrome 89+ isBeginMeasuredFrame
00:00 +7 -1: test\adb_test.dart: device adb startLoggingToSink calls adb [E]
  DeviceException: The ANDROID_HOME environment variable is missing. The variable must point to the Android SDK directory containing platform-tools.
  package:flutter_devicelab/framework/devices.dart 1471:5  adbPath
  package:flutter_devicelab/framework/devices.dart 784:7   AndroidDevice.startLoggingToSink
  ===== asynchronous gap ===========================
  test\adb_test.dart 257:9                                 main.<fn>.<fn>.<fn>

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8690761195114703281/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout?format=raw

In theory it might be enough to just add the android_sdk dependency, but I also added the remaining dependencies to keep it the same as framework_tests_misc, since it makes sense for the two tasks to have identical dependencies.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@dkwingsmt dkwingsmt requested a review from jtmcdole February 4, 2026 22:43
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds missing dependencies (vs_build, open_jdk, and android_sdk) to the framework_tests_misc_leak_tracking CI task. This change aims to fix a recurring CI failure due to a missing Android SDK and to align the task's dependencies with those of framework_tests_misc. The change is correct and addresses the issue described. I have provided one suggestion to sort the dependencies for improved maintainability.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 10, 2026
Merged via the queue into flutter:master with commit a693bbe Feb 10, 2026
154 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 10, 2026
Roll Flutter from e8f9dc50356d to 9bda20a11f1e (34 revisions)

flutter/flutter@e8f9dc5...9bda20a

2026-02-10 brackenavaron@gmail.com Remove Material import from focus_traversal_test.dart (flutter/flutter#180994)
2026-02-10 engine-flutter-autoroll@skia.org Roll Skia from 6e217430c052 to cffb3bf918df (1 revision) (flutter/flutter#182131)
2026-02-10 divyansh.shah.ece23@itbhu.ac.in Encourage splitting large test files in testing documentation 2 (flutter/flutter#182051)
2026-02-10 34465683+rkishan516@users.noreply.github.com refactor: migrate CupertinoPageTransitionsBuilder to cupertino folder (flutter/flutter#179776)
2026-02-10 30870216+gaaclarke@users.noreply.github.com Delete the last remaining skia only fragment shader tests (flutter/flutter#182127)
2026-02-10 jhy03261997@gmail.com [a11y][android] Set new CheckState APIs for android API 36  (flutter/flutter#182113)
2026-02-10 dkwingsmt@users.noreply.github.com Add missing dependencies to framework_tests_misc_leak_tracking (flutter/flutter#181929)
2026-02-10 engine-flutter-autoroll@skia.org Roll Dart SDK from eee0e2e11174 to 69eb951f8f7e (2 revisions) (flutter/flutter#182128)
2026-02-10 fluttergithubbot@gmail.com Marks Linux_android_emu android_display_cutout to be flaky (flutter/flutter#181901)
2026-02-10 737941+loic-sharma@users.noreply.github.com Bump Dart to 3.10 (flutter/flutter#174066)
2026-02-10 engine-flutter-autoroll@skia.org Roll Skia from d4b7e24a209b to 6e217430c052 (6 revisions) (flutter/flutter#182126)
2026-02-09 15619084+vashworth@users.noreply.github.com Intercept UIScene device log and print a guided warning (flutter/flutter#181515)
2026-02-09 47866232+chunhtai@users.noreply.github.com Introduce ScrollCacheExtent and also fixes unbound shrinkwrap cache ex… (flutter/flutter#181092)
2026-02-09 43054281+camsim99@users.noreply.github.com [Android] Add mechanism for setting Android engine flags via Android manifest (take 2) (flutter/flutter#181632)
2026-02-09 116356835+AbdeMohlbi@users.noreply.github.com Fix wrong comment about default impeller value (flutter/flutter#181831)
2026-02-09 huqian123hq@hotmail.com fix build fail for wayland only platform (flutter/flutter#182057)
2026-02-09 jesswon@google.com [AGP 9] Added Warning Against Updating to AGP 9 (flutter/flutter#181977)
2026-02-09 30870216+gaaclarke@users.noreply.github.com Updated Shaderc dep (flutter/flutter#180976)
2026-02-09 47866232+chunhtai@users.noreply.github.com Refactor accessibility guidelines out to widget layer (flutter/flutter#181672)
2026-02-09 engine-flutter-autoroll@skia.org Roll Skia from 68dff53238e5 to d4b7e24a209b (2 revisions) (flutter/flutter#182087)
2026-02-09 ikramhasan.dev@gmail.com fix: OutlineInputBorder not respecting BorderSide stroke alignment (flutter/flutter#180487)
2026-02-09 97480502+b-luk@users.noreply.github.com Adds opengles to engine dart tests (flutter/flutter#181933)
2026-02-09 15619084+vashworth@users.noreply.github.com Add command to build a Swift Package for Add to App and generate FlutterPluginRegistrant (flutter/flutter#181224)
2026-02-09 116356835+AbdeMohlbi@users.noreply.github.com Remove unused constant in `bundle.dart` (flutter/flutter#182023)
2026-02-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from iqtwdXlgKIyZkL5Li... to 7BGf7mPQvgLi7Axb6... (flutter/flutter#182082)
2026-02-09 116356835+AbdeMohlbi@users.noreply.github.com Remove unused getters in `user_messages.dart` (flutter/flutter#181867)
2026-02-09 engine-flutter-autoroll@skia.org Roll Packages from 7805d3e to 3d5eaa5 (3 revisions) (flutter/flutter#182083)
2026-02-09 engine-flutter-autoroll@skia.org Roll Skia from 5d891cd7fb7f to 68dff53238e5 (1 revision) (flutter/flutter#182080)
2026-02-09 robert.ancell@canonical.com Update example description (flutter/flutter#182067)
2026-02-09 engine-flutter-autoroll@skia.org Roll Dart SDK from 965b51c219d3 to eee0e2e11174 (1 revision) (flutter/flutter#182073)
2026-02-09 engine-flutter-autoroll@skia.org Roll Skia from 9533d7533d59 to 5d891cd7fb7f (6 revisions) (flutter/flutter#182070)
2026-02-09 jwren@google.com Add a new flutter cli command, running-apps, using mDNS app discovery (flutter/flutter#180098)
2026-02-09 engine-flutter-autoroll@skia.org Roll Skia from b7db9f35f0f2 to 9533d7533d59 (2 revisions) (flutter/flutter#182069)
2026-02-08 robert.ancell@canonical.com Improve FlWindowMonitor API (flutter/flutter#181885)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
…er#181929)

This PR adds more dependencies to the CI task
`framework_tests_misc_leak_tracking` so that it has the same
dependencies as `framework_tests_misc`.

This is to fix a consistent failure currently in the
`framework_tests_misc_leak_tracking` task about missing Android SDK:
```
00:00 +7: test\adb_test.dart: device adb startLoggingToSink calls adb
00:00 +7 -1: test\framework\browser_test.dart: BlinkTraceEvent works with Chrome 89+ isBeginMeasuredFrame
00:00 +7 -1: test\adb_test.dart: device adb startLoggingToSink calls adb [E]
  DeviceException: The ANDROID_HOME environment variable is missing. The variable must point to the Android SDK directory containing platform-tools.
  package:flutter_devicelab/framework/devices.dart 1471:5  adbPath
  package:flutter_devicelab/framework/devices.dart 784:7   AndroidDevice.startLoggingToSink
  ===== asynchronous gap ===========================
  test\adb_test.dart 257:9                                 main.<fn>.<fn>.<fn>
```

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8690761195114703281/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout?format=raw

In theory it might be enough to just add the `android_sdk` dependency,
but I also added the remaining dependencies to keep it the same as
`framework_tests_misc`, since it makes sense for the two tasks to have
identical dependencies.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
…er#181929)

This PR adds more dependencies to the CI task
`framework_tests_misc_leak_tracking` so that it has the same
dependencies as `framework_tests_misc`.

This is to fix a consistent failure currently in the
`framework_tests_misc_leak_tracking` task about missing Android SDK:
```
00:00 +7: test\adb_test.dart: device adb startLoggingToSink calls adb
00:00 +7 -1: test\framework\browser_test.dart: BlinkTraceEvent works with Chrome 89+ isBeginMeasuredFrame
00:00 +7 -1: test\adb_test.dart: device adb startLoggingToSink calls adb [E]
  DeviceException: The ANDROID_HOME environment variable is missing. The variable must point to the Android SDK directory containing platform-tools.
  package:flutter_devicelab/framework/devices.dart 1471:5  adbPath
  package:flutter_devicelab/framework/devices.dart 784:7   AndroidDevice.startLoggingToSink
  ===== asynchronous gap ===========================
  test\adb_test.dart 257:9                                 main.<fn>.<fn>.<fn>
```

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8690761195114703281/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout?format=raw

In theory it might be enough to just add the `android_sdk` dependency,
but I also added the remaining dependencies to keep it the same as
`framework_tests_misc`, since it makes sense for the two tasks to have
identical dependencies.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants