Prompt plugin authors to add Swift Package Manager compatibility to their plugin#182246
Merged
auto-submit[bot] merged 13 commits intoflutter:masterfrom Mar 19, 2026
Merged
Prompt plugin authors to add Swift Package Manager compatibility to their plugin#182246auto-submit[bot] merged 13 commits intoflutter:masterfrom
auto-submit[bot] merged 13 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
the
tool
okorohelijah
changed the title
Contributor
Author
|
The doc for migrating to spm doesnt seem to include adding the FlutterFramework dependency. I plan on updating it |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a validation check to prompt plugin authors to add Swift Package Manager (SPM) compatibility for their iOS and macOS plugins. The check runs when refreshPluginsList is called for a plugin's example app. It verifies if a plugin with a podspec also has a Package.swift file, and if so, whether it correctly depends on FlutterFramework. Warnings are displayed to guide plugin authors on how to add or fix their SPM support. The changes include new logic in flutter_plugins.dart and plugins.dart, along with corresponding unit tests.
vashworth
reviewed
Feb 17, 2026
Contributor
vashworth
left a comment
vashworth
left a comment
There was a problem hiding this comment.
Can you move all logic into DarwinDependencyManagement?
github-actions
bot
added
a: desktop
vashworth
reviewed
Feb 18, 2026
| ' .package(name: "FlutterFramework", path: "../FlutterFramework")\n' | ||
| 'And add FlutterFramework as a target dependency:\n' | ||
| ' .product(name: "FlutterFramework", package: "FlutterFramework")\n' | ||
| 'See $kSwiftPackageManagerDocsUrl for more information.', |
Contributor
There was a problem hiding this comment.
Let's wait for flutter/website#12979 to land, so we can point to the docs
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
| /// | ||
| /// This looks for common patterns used to declare a FlutterFramework dependency: | ||
| /// - `.package(name: "FlutterFramework", path: "../FlutterFramework")` - package dependency | ||
| /// - `.product(name: "FlutterFramework", package: "FlutterFramework")` - target dependency |
Contributor
There was a problem hiding this comment.
I'm not familiar with SwiftPM, but can target dependency be just a string (if no naming conflict)? Something like:
dependencies: [
"FlutterFramework",
]
Contributor
There was a problem hiding this comment.
This seems to be outstanding? @vashworth is this a possible case that we should watch out?
| class SwiftPackageManagerPluginValidationResult { | ||
| SwiftPackageManagerPluginValidationResult({ | ||
| required this.hasPodspec, | ||
| required this.hasPackageSwift, |
Contributor
There was a problem hiding this comment.
Nit: I assume this refers to "Package.swift" file? How about hasSwiftPMManifest?
| final bool hasFlutterFrameworkDependency; | ||
| final List<String> validationMessages; | ||
|
|
||
| bool get isFullyCompatible => hasPackageSwift && hasFlutterFrameworkDependency; |
Contributor
There was a problem hiding this comment.
what does "fully compatible" mean? (and what is "partially" compatible? the ones without
"FlutterFramework" dependency?
vashworth
reviewed
Feb 27, 2026
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart
Outdated
Show resolved
Hide resolved
okorohelijah
force-pushed
the
fix_148222
branch
from
8272e14 to
0080a40
Compare
github-actions
bot
removed
platform-ios
# Conflicts: # packages/flutter_tools/test/general.shard/macos/darwin_dependency_management_test.dart
okorohelijah
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…ility to their plugin (flutter/flutter#182246)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2026
…ility to their plugin (flutter/flutter#182246)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ility to their plugin (flutter/flutter#182246)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ility to their plugin (flutter/flutter#182246)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ility to their plugin (flutter/flutter#182246)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ility to their plugin (flutter/flutter#182246)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ility to their plugin (flutter/flutter#182246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt plugin authors to add Swift Package Manager compatibility to their plugin
Fixes #148222
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.