Migrate addTaskForPrintBuildVariants and isFlutterAppProject to new agp dsl#183849
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Mar 19, 2026
Merged
Conversation
github-actions
bot
added
platform-android
gmackall
commented
Mar 18, 2026
| project.extensions.getByType(ApplicationExtension::class.java) | ||
|
|
||
| // Avoid new usages this class is not part of the public AGP DSL. | ||
| private fun getAndroidAppExtensionOrNull(project: Project): AbstractAppExtension? = |
Member
Author
There was a problem hiding this comment.
I also deleted this as it was unused
added 2 commits
March 18, 2026 11:57
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates addTaskForPrintBuildVariants and isFlutterAppProject to use the new AGP DSL, replacing deprecated AbstractAppExtension with ApplicationExtension and AndroidComponentsExtension. The changes involve updating the Gradle plugin and test files to reflect these API changes. The code review focuses on ensuring the correctness of the migration and adherence to the repository's style guide.
reidbaker
approved these changes
Mar 19, 2026
gmackall
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ject` to new agp dsl (flutter/flutter#183849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ject` to new agp dsl (flutter/flutter#183849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ject` to new agp dsl (flutter/flutter#183849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ject` to new agp dsl (flutter/flutter#183849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2026
…ject` to new agp dsl (flutter/flutter#183849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2026
…ject` to new agp dsl (flutter/flutter#183849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2026
…ject` to new agp dsl (flutter/flutter#183849)
This was referenced Mar 21, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2026
…ject` to new agp dsl (flutter/flutter#183849)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate addTaskForPrintBuildVariants and isFlutterAppProject to new agp dsl