Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions engine/src/flutter/impeller/display_list/aiks_dl_blur_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1509,5 +1509,25 @@ TEST_P(AiksTest, CanRenderNestedBackdropBlur) {
ASSERT_TRUE(OpenPlaygroundHere(callback));
}

TEST_P(AiksTest, GaussianBlurFlipped) {
DisplayListBuilder builder;
builder.Scale(GetContentScale().x, GetContentScale().y);

builder.DrawRect(DlRect::MakeXYWH(0, 0, 350, 350),
DlPaint().setColor(DlColor::kWhite()));

builder.Save();
builder.Scale(-1, 1);
DlPaint paint;
paint.setImageFilter(DlBlurImageFilter::Make(10, 10, DlTileMode::kDecal));
builder.SaveLayer(DlRect::MakeLTRB(-150, 100, 150, 200), &paint);
builder.DrawRect(DlRect::MakeLTRB(-150, 0, 150, 300),
DlPaint().setColor(DlColor::kRed()));
builder.Restore();
builder.Restore();

ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
}

} // namespace testing
} // namespace impeller
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,8 @@ std::optional<Rect> GaussianBlurFilterContents::GetFilterSourceCoverage(
Vector2 blur_radius = {CalculateBlurRadius(scaled_sigma.x),
CalculateBlurRadius(scaled_sigma.y)};
Vector3 blur_radii =
effect_transform.Basis() * Vector3{blur_radius.x, blur_radius.y, 0.0};
(effect_transform.Basis() * Vector3{blur_radius.x, blur_radius.y, 0.0})
.Abs();
return output_limit.Expand(Point(blur_radii.x, blur_radii.y));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,26 @@ TEST(GaussianBlurFilterContentsTest, FilterSourceCoverage) {
}
}

TEST(GaussianBlurFilterContentsTest, FilterSourceCoverageNegativeScale) {
fml::StatusOr<Scalar> sigma_radius_1 =
CalculateSigmaForBlurRadius(1.0, Matrix());
ASSERT_TRUE(sigma_radius_1.ok());
auto contents = std::make_unique<GaussianBlurFilterContents>(
sigma_radius_1.value(), sigma_radius_1.value(), Entity::TileMode::kDecal,
/*bounds=*/std::nullopt, FilterContents::BlurStyle::kNormal,
/*mask_geometry=*/nullptr);

// Negative scale should still result in an expanded coverage rect.
std::optional<Rect> coverage = contents->GetFilterSourceCoverage(
/*effect_transform=*/Matrix::MakeScale({-2.0, 2.0, 1.0}),
/*output_limit=*/Rect::MakeLTRB(100, 100, 200, 200));
ASSERT_TRUE(coverage.has_value());
if (coverage.has_value()) {
EXPECT_RECT_NEAR(coverage.value(),
Rect::MakeLTRB(100 - 2, 100 - 2, 200 + 2, 200 + 2));
}
}

TEST(GaussianBlurFilterContentsTest, CalculateSigmaValues) {
EXPECT_EQ(GaussianBlurFilterContents::CalculateScale(1.0f), 1);
EXPECT_EQ(GaussianBlurFilterContents::CalculateScale(2.0f), 1);
Expand Down