Update TabBar documentation to clarify indicatorWeight behavior#184104
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the TabBar widget in packages/flutter/lib/src/material/tabs.dart. The change clarifies that while indicatorWeight does not affect the visual appearance of the indicator when a custom indicator is provided, it may still be used to compute the TabBar's preferred size. There is no specific feedback to provide on the changes.
| /// then [indicatorColor] is ignored. | ||
| /// | ||
| /// The [indicatorWeight] does not affect the visual appearance of | ||
| /// the indicator when a custom [indicator] is provided. However, | ||
| /// it may still be used to compute the TabBar's preferred size. |
There was a problem hiding this comment.
0a95c29 to
91112dd
Compare
Clarifies that indicatorWeight does not affect painting when a custom indicator is provided, but may still influence the preferred size.
91112dd to
fa4a0ff
Compare
Description
Updates the documentation of
TabBarto clarify the behavior ofindicatorWeightwhen a customindicatoris provided.Previously, the documentation stated that
indicatorWeightis ignored when anindicatoris specified. However,indicatorWeightis still used internally to compute thepreferredSizeof theTabBar, which can affect layout.This change clarifies that:
indicatorWeightdoes not affect the visual appearance of the indicator when a customindicatoris providedTabBarRelated Issue
Fixes #171951
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.