Skip to content

forward an application name to DDS#184459

Merged
jakemac53 merged 9 commits into
flutter:masterfrom
jakemac53:dds-app-name
Apr 2, 2026
Merged

forward an application name to DDS#184459
jakemac53 merged 9 commits into
flutter:masterfrom
jakemac53:dds-app-name

Conversation

@jakemac53
Copy link
Copy Markdown
Contributor

@jakemac53 jakemac53 commented Apr 1, 2026 •
edited
Loading

Fixes #184251

  • Updates DDS to version 5.3.0 in flutter_tool.
  • Uses the new appName parameter to pass a short description of the app.
    • Added this as an optional (for now) parameter in all the internal wrappers around this API. All apps should have an app name.
    • Updated all places to pass something sensible, typically a combination of the device display string and flutter package name. We may want to expand on this later.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@jakemac53 jakemac53 requested a review from bkonyi April 1, 2026 15:03
@jakemac53 jakemac53 added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 1, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dds dependency to version 5.3.0 and introduces a required appName parameter to the Dart Development Service (DDS) startup methods across the flutter_tools package. This parameter provides metadata about the application being debugged. The review feedback indicates that relying on FlutterProject.current() in daemon.dart and resident_runner.dart is potentially unreliable as it depends on the current working directory, and suggests using specific project or package instances for better accuracy.

Comment thread packages/flutter_tools/lib/src/commands/daemon.dart Outdated
Comment thread packages/flutter_tools/lib/src/resident_runner.dart
@jakemac53
Copy link
Copy Markdown
Contributor Author

jakemac53 commented Apr 1, 2026

Looks like I will have to make these arguments non-required for internal rolling purposes.

After the roll we should ideally update though so that they are required, but I am not really sure how to best deal with that in flutter (do we have a hot patch equivalent like the dart SDK?).

bkonyi
bkonyi previously approved these changes Apr 1, 2026
View reviewed changes
Comment thread packages/flutter_tools/lib/src/commands/daemon.dart Outdated
Comment thread packages/flutter_tools/lib/src/resident_runner.dart
@jakemac53 jakemac53 requested a review from bkonyi April 1, 2026 17:35
bkonyi
bkonyi previously approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once a G3Fix is uploaded.

@jakemac53 jakemac53 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2026
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented Apr 2, 2026

auto label is removed for flutter/flutter/184459, Failed to enqueue flutter/flutter/184459 with HTTP 400: GraphQL mutate failed.

@jakemac53 jakemac53 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2026
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented Apr 2, 2026

auto label is removed for flutter/flutter/184459, Failed to enqueue flutter/flutter/184459 with HTTP 400: GraphQL mutate failed.

@jakemac53 jakemac53 enabled auto-merge April 2, 2026 18:30
@jakemac53 jakemac53 added the CICD Run CI/CD label Apr 2, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 2, 2026
@jakemac53 jakemac53 added the CICD Run CI/CD label Apr 2, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 2, 2026
@jakemac53 jakemac53 added the CICD Run CI/CD label Apr 2, 2026
bkonyi
bkonyi previously approved these changes Apr 2, 2026
View reviewed changes
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 2, 2026
@jakemac53 jakemac53 added the CICD Run CI/CD label Apr 2, 2026
@jakemac53 jakemac53 requested a review from kenzieschmoll April 2, 2026 21:28
kenzieschmoll
kenzieschmoll previously approved these changes Apr 2, 2026
View reviewed changes
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 2, 2026
@jakemac53 jakemac53 added the CICD Run CI/CD label Apr 2, 2026
@jakemac53 jakemac53 added this pull request to the merge queue Apr 2, 2026
Merged via the queue into flutter:master with commit 3f4c99f Apr 2, 2026
137 of 139 checks passed
@jakemac53 jakemac53 deleted the dds-app-name branch April 2, 2026 23:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2026
@engine-flutter-autoroll
3f4c99fae forward an application name to DDS (flutter/flutter#184459)
d68f8a9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 3, 2026
@engine-flutter-autoroll
Roll Flutter from 0f401eea0439 to 7245c3f71104 (25 revisions) (#11427)
a95e1c3 
flutter/flutter@0f401ee...7245c3f

2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from c07c67045b6d to 5d847ba5c4aa (1 revision) (flutter/flutter#184570)
2026-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 3c7a79045b8b to 46f49142acd9 (1 revision) (flutter/flutter#184567)
2026-04-03 engine-flutter-autoroll@skia.org Roll ICU from ee5f27adc28b to ff7995a708a1 (5 revisions) (flutter/flutter#184566)
2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 9ae8231be181 to c07c67045b6d (4 revisions) (flutter/flutter#184562)
2026-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BFLjk6Uwd0gs_Hkdk... to PpL3Bn2YMb2h9LbdK... (flutter/flutter#184556)
2026-04-03 engine-flutter-autoroll@skia.org Roll Skia from 0566b2f5f0d1 to 9ae8231be181 (1 revision) (flutter/flutter#184547)
2026-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 6008eaddd589 to 3c7a79045b8b (3 revisions) (flutter/flutter#184551)
2026-04-03 evanwall@buffalo.edu Fix wide gamut macos integration test (flutter/flutter#184427)
2026-04-02 jakemac@google.com forward an application name to DDS (flutter/flutter#184459)
2026-04-02 engine-flutter-autoroll@skia.org Roll Skia from 973117cfa875 to 0566b2f5f0d1 (8 revisions) (flutter/flutter#184534)
2026-04-02 97480502+b-luk@users.noreply.github.com Support different joins for stroked rects in uber_sdf, fix incorrect aa (flutter/flutter#184395)
2026-04-02 bkonyi@google.com [ Widget Preview ] Handle collections and records in custom preview annotations (flutter/flutter#184518)
2026-04-02 47866232+chunhtai@users.noreply.github.com Moves android_semantics_integration_test out of staging (flutter/flutter#184079)
2026-04-02 engine-flutter-autoroll@skia.org Roll Packages from b3fcf14 to 66bf7ec (4 revisions) (flutter/flutter#184514)
2026-04-02 rmolivares@renzo-olivares.dev Fix line breaks being lost when copying after selection gesture in SelectableRegion (flutter/flutter#184421)
2026-04-02 15619084+vashworth@users.noreply.github.com Add plugin version to SwiftPM package symlink directory (flutter/flutter#183668)
2026-04-02 34871572+gmackall@users.noreply.github.com Add our own wrapper for `CommonExtension` due to change in signature from 8.x->9.0 (flutter/flutter#184433)
2026-04-02 dbebawy@users.noreply.github.com [Android] Use EdgeToEdge.enable/WindowCompat for edge-to-edge mode instead of deprecated View flags (flutter/flutter#183072)
2026-04-02 dacoharkes@google.com [data_assets] Cleanup tests (flutter/flutter#184209)
2026-04-02 okorohelijah@google.com Enable SPM by default on Stable (flutter/flutter#184495)
2026-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from d84bdfeb45eb to 6008eaddd589 (2 revisions) (flutter/flutter#184513)
2026-04-02 victorsanniay@gmail.com Reland "Even more awaits" (flutter/flutter#184467)
2026-04-02 engine-flutter-autoroll@skia.org Roll Skia from bb9fd8653739 to 973117cfa875 (2 revisions) (flutter/flutter#184498)
2026-04-02 bkonyi@google.com [ Widget Preview ] Use analysis server for widget preview detection (flutter/flutter#184473)
2026-04-02 srawlins@google.com [web_ui] Fix avoid_type_to_string lint violation (flutter/flutter#184342)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
@jakemac53 @mbcorona
forward an application name to DDS (flutter#184459)
4d37449 
Fixes flutter#184251

- Updates DDS to version `5.3.0` in flutter_tool.
- Uses the new `appName` parameter to pass a short description of the
app.
- Added this as an optional (for now) parameter in all the internal
wrappers around this API. All apps should have an app name.
- Updated all places to pass something sensible, typically a combination
of the device display string and flutter package name. We may want to
expand on this later.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi bkonyi left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apps are registered to DTD without a name, making it hard for agents to disambiguate

3 participants

@jakemac53 @bkonyi @kenzieschmoll