Skip to content

Revert "Add Support For Built-in Kotlin (#184227)"#184739

Merged
Renzo-Olivares merged 1 commit into
flutter:masterfrom
Renzo-Olivares:manual-revert-184227
Apr 7, 2026
Merged

Revert "Add Support For Built-in Kotlin (#184227)"#184739
Renzo-Olivares merged 1 commit into
flutter:masterfrom
Renzo-Olivares:manual-revert-184227

Conversation

@Renzo-Olivares
Copy link
Copy Markdown
Contributor

@Renzo-Olivares Renzo-Olivares commented Apr 7, 2026 •
edited
Loading

This reverts commit 3d41f26 to fix the tree breakage, more details in #184736.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@Renzo-Olivares Renzo-Olivares requested a review from a team as a code owner April 7, 2026 21:14
@reidbaker reidbaker requested a review from jesswrd April 7, 2026 21:17
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Gradle lockfiles across multiple directories, including benchmarks and integration tests. The changes involve removing various dependencies and updating dependency configurations. I have no feedback to provide as these changes appear to be routine dependency management updates.

@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Apr 7, 2026
@Renzo-Olivares Renzo-Olivares added the CICD Run CI/CD label Apr 7, 2026
@gmackall
Copy link
Copy Markdown
Member

gmackall commented Apr 7, 2026

This will need the emergency label to merge, right? Otherwise it will be blocked by tree-status

@Renzo-Olivares Renzo-Olivares added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Apr 7, 2026
@flutter-dashboard
Copy link
Copy Markdown

flutter-dashboard Bot commented Apr 7, 2026

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@Renzo-Olivares Renzo-Olivares added this pull request to the merge queue Apr 7, 2026
Merged via the queue into flutter:master with commit 428e344 Apr 7, 2026
147 of 148 checks passed
@Renzo-Olivares Renzo-Olivares deleted the manual-revert-184227 branch April 7, 2026 22:25
@Renzo-Olivares Renzo-Olivares mentioned this pull request Apr 8, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2026
@engine-flutter-autoroll
428e34414 Revert "Add Support For Built-in Kotlin (#184227)" (flutter…
175a5fd 
…/flutter#184739)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2026
@engine-flutter-autoroll
428e34414 Revert "Add Support For Built-in Kotlin (#184227)" (flutter…
f01585c 
…/flutter#184739)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 8, 2026
@engine-flutter-autoroll
Roll Flutter from a0924c76b0fd to 05e0ae02600d (24 revisions) (#11470)
03b36d6 
flutter/flutter@a0924c7...05e0ae0

2026-04-08 meylis@divine.video Fix Android engine flags defaulting to true for malformed values (flutter/flutter#184631)
2026-04-08 katelovett@google.com Try one more again (flutter/flutter#184767)
2026-04-08 goderbauer@google.com Remove custom `analysis_options.yaml` from `imitation_game_flutter` (flutter/flutter#184717)
2026-04-08 victorsanniay@gmail.com Add more error handling to unawaited callsites (flutter/flutter#184526)
2026-04-08 34465683+rkishan516@users.noreply.github.com Refactor: remove material from absorb_ponter_test, container_test,  lookup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test (flutter/flutter#183309)
2026-04-08 73785960+xfce0@users.noreply.github.com Remove editable_text_utils cross-imports from material and cupertino … (flutter/flutter#184519)
2026-04-08 robert.ancell@canonical.com Replace hard coded max path length with system defined one. (flutter/flutter#184697)
2026-04-08 jesswon@google.com [Re-land] Add Support For Built-in Kotlin (flutter/flutter#184745)
2026-04-08 15619084+vashworth@users.noreply.github.com Manually stop and continue LLDB breakpoints on Xcode 26.4+ (flutter/flutter#184690)
2026-04-08 katelovett@google.com Code freeze workflow (flutter/flutter#184246)
2026-04-08 737941+loic-sharma@users.noreply.github.com [Dot shorthands] Migrate examples/api/lib/widgets (flutter/flutter#183965)
2026-04-08 59215665+davidhicks980@users.noreply.github.com [cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (flutter/flutter#182036)
2026-04-08 87018443+mayanksharma9@users.noreply.github.com [Semantics] clarify Android header docs (flutter/flutter#183573)
2026-04-08 dacoharkes@google.com [ci] mac build_test bringup false (flutter/flutter#184738)
2026-04-08 34871572+gmackall@users.noreply.github.com Reland "Apply rect clipping to surface views" (flutter/flutter#184732)
2026-04-08 bkonyi@google.com Remove bringup label for resharded Windows tool_integration_tests shards (flutter/flutter#184721)
2026-04-08 namangoyaldev@gmail.com Tool: Add search and filtering to widget preview scaffold (flutter/flutter#184023)
2026-04-08 36861262+QuncCccccc@users.noreply.github.com Update localization from translation console (flutter/flutter#184742)
2026-04-07 rmolivares@renzo-olivares.dev Revert "Add Support For Built-in Kotlin (#184227)" (flutter/flutter#184739)
2026-04-07 34871572+gmackall@users.noreply.github.com Collect HCPP adoption analytics for flutter run/build apk/build appbundle (flutter/flutter#184225)
2026-04-07 jacksongardner@google.com Add a github workflow for reverting PRs. (flutter/flutter#184593)
2026-04-07 jesswon@google.com Add Support For Built-in Kotlin (flutter/flutter#184227)
2026-04-07 34871572+gmackall@users.noreply.github.com Revert "Apply rect clipping to surface views (#184471)" (flutter/flutter#184728)
2026-04-07 jesswon@google.com [Fix-forward] Added Compose plugin to Add-to-app Integration Test (flutter/flutter#184681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
@Renzo-Olivares @mbcorona
Revert "Add Support For Built-in Kotlin (flutter#184227)" (flutter#18…
e44dce1 
…4739)

This reverts commit 3d41f26 to fix the
tree breakage, more details in
flutter#184736.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

Co-authored-by: Renzo Olivares <roliv@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jesswrd jesswrd jesswrd approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests CICD Run CI/CD d: examples Sample code and demos emergency Jump the queue; land PR in front of all others; only use for emergencies f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Renzo-Olivares @gmackall @reidbaker @jesswrd