Skip to content

Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors#185033

Merged
jtmcdole merged 1 commit intoflutter:masterfrom
reidbaker:r-lint-flutter-flutter-skills
Apr 17, 2026
Merged

Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors#185033
jtmcdole merged 1 commit intoflutter:masterfrom
reidbaker:r-lint-flutter-flutter-skills

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

@reidbaker reidbaker commented Apr 14, 2026

Add a static analysis linter for skills authors in flutter/flutter

I want to call out that this is adding a dependency on repo we control but is not yet available in pub.dev.

Update deps also had me fix an build error caused by updating build_runner.

Pre-launch Checklist

@reidbaker reidbaker requested a review from jtmcdole as a code owner April 14, 2026 15:59
@reidbaker reidbaker requested a review from bkonyi April 14, 2026 15:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for validating skills and introduces an automated validation test using the dart_skills_lint package. The review feedback suggests pinning the git dependency to a specific commit hash to ensure deterministic builds and improving test isolation by restoring the global logger level after the test completes.

Comment thread dev/tools/pubspec.yaml
Comment thread dev/tools/test/validate_skills_test.dart
Comment thread dev/tools/test/validate_skills_test.dart
bkonyi
bkonyi previously approved these changes Apr 14, 2026
jtmcdole
jtmcdole previously approved these changes Apr 14, 2026
Comment thread .agents/skills/README.md
@reidbaker reidbaker added the CICD Run CI/CD label Apr 14, 2026
@reidbaker reidbaker dismissed stale reviews from jtmcdole and bkonyi via 9de965f April 14, 2026 19:29
@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. CICD Run CI/CD and removed CICD Run CI/CD labels Apr 14, 2026
@reidbaker
Copy link
Copy Markdown
Contributor Author

Test failures appear to be from tip of tree. Will wait until the tree is green the sync and rerun cicd.

@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 14, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Apr 14, 2026
@jtmcdole
Copy link
Copy Markdown
Member

There's a license missing:

The following file does not have the right license header for dart files:
  /b/s/w/ir/x/w/flutter/dev/tools/test/validate_skills_test.dart
The expected license header is:
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

and the tools tests are failing

@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Apr 15, 2026
@reidbaker reidbaker requested review from bkonyi and jtmcdole April 15, 2026 15:14
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Apr 16, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Apr 16, 2026
url_launcher: any
web: any
webview_flutter: any
async: any
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't look like it was intended, or was it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad merge resolution that was required because head was broken. Fixed now.

@bkonyi
Copy link
Copy Markdown
Contributor

bkonyi commented Apr 16, 2026

I don't think we need to upgrade versions in the pubspecs to add the git dependency. If you revert those changes and run flutter update-packages --update-hashes that should be enough.

@reidbaker reidbaker force-pushed the r-lint-flutter-flutter-skills branch from 33f503d to 9749e1e Compare April 16, 2026 19:23
@github-actions github-actions Bot removed tool Affects the "flutter" command-line tool. See also t: labels. CICD Run CI/CD labels Apr 16, 2026
@reidbaker reidbaker requested a review from bkonyi April 16, 2026 19:24
@reidbaker reidbaker added the CICD Run CI/CD label Apr 16, 2026
@reidbaker
Copy link
Copy Markdown
Contributor Author

I don't think we need to upgrade versions in the pubspecs to add the git dependency. If you revert those changes and run flutter update-packages --update-hashes that should be enough.

FWIW I ran flutter update-packages because the test that failed lock file checking said that was the command to run. PR now only uses --update-hashes

@reidbaker reidbaker force-pushed the r-lint-flutter-flutter-skills branch from 9749e1e to 0c3d241 Compare April 16, 2026 21:25
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026
@reidbaker reidbaker added the CICD Run CI/CD label Apr 16, 2026
@jtmcdole jtmcdole added this pull request to the merge queue Apr 16, 2026
Merged via the queue into flutter:master with commit 3d6ef4e Apr 17, 2026
161 of 162 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 17, 2026
flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 chris@bracken.jp [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 pewpewstol@gmail.com [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 nate.w5687@gmail.com `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 karan@solvejet.net Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 154381524+flutteractionsbot@users.noreply.github.com Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 116356835+AbdeMohlbi@users.noreply.github.com Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 1063596+reidbaker@users.noreply.github.com Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 flar@google.com [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 katelovett@google.com Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 152433210+mozammal-hossain@users.noreply.github.com [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 bkonyi@google.com [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 sigurdm@google.com Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 68919043+Istiak-Ahmed78@users.noreply.github.com Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 154381524+flutteractionsbot@users.noreply.github.com Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker deleted the r-lint-flutter-flutter-skills branch April 17, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants