[CP-beta]Fix an ordering dependency in the services/system_chrome_test.dart test suite#185104
Conversation
…st suite (flutter#185086) The "SystemChrome overlay style test" assumed that the overlay style was not set to SystemUiOverlayStyle.light at the start of the test. That may not be the case if other tests previously modified that state. Fixes flutter#185085
|
@eyebrowsoffire please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
Bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the system_chrome_test.dart file to include an explicit initial state setup. It sets the system UI overlay style to dark, waits for the tester to be idle, and clears the log before proceeding with the existing test for cache miss behavior. I have no feedback to provide.
eyebrowsoffire
added
the
autosubmit
auto-submit
Bot
merged commit 2df29e9
into
flutter:flutter-3.44-candidate.0
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
https://github.com/flutter/flutter/issues/< Replace with issue link here >
Impact Description:
This is a test-only change which removes some dependency on ordering of tests.
Changelog Description:
This change is test-only and does not require a changelog entry.
Workaround:
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
Run CI and ensure the tests pass.