Parse common SwiftPM errors and only fetch Swift packages when project is using SwiftPM by vashworth · Pull Request #185218 · flutter/flutter

vashworth · 2026-04-17T19:58:46Z

This PR does the following:

Moves prefetchSwiftPackages logic from the XcodeProjectInterpreter class to the XcodeBasedProject class so that it can be run per platform (ios, macos)
Changes projectPath parameter from a String to XcodeBasedProject
Skips prefetchSwiftPackages is project has not been migrated to SwiftPM
Adds a call to SwiftPackageManagerIntegrationMigration that prefetches the dependencies
Parses common errors that may occur when prefetching SwiftPM dependencies

Addresses #184021.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request introduces a mechanism to parse and report specific Swift Package Manager errors related to Flutter plugins during build and migration processes. It adds a parseError utility in SwiftPackageManager and integrates it into the iOS build and migration logic. Review feedback identifies a logic error in xcodeproj.dart where the incorrect directory is used to find the Flutter project, and suggests using allMatches instead of firstMatch in the error parser to ensure all potential plugin errors are evaluated.

flutter-dashboard · 2026-04-30T21:44:26Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gemini-code-assist

Code Review

This pull request enhances Swift Package Manager integration by introducing guided error messages for common plugin configuration issues. It implements a parsing mechanism for SwiftPM error output and updates the prefetchSwiftPackages method with a force flag. The migration process is also updated to include a prefetch step with specific error handling. Feedback suggests refining the error-matching regular expressions to support common subdirectories and versioned plugin directories in the pub cache.

vashworth · 2026-05-05T17:15:13Z

    });
  });
+
+  testWithoutContext(


These tests are copy/pasted with some slight tweaks since it's a new class.

vashworth · 2026-05-05T17:15:37Z

+    );
+  });
+
+  testWithoutContext('prefetchSwiftPackages can run for both platforms', () async {


This is a new test

hellohuanlin · 2026-05-06T16:23:47Z

Saw you are still updating this PR. Just double check if this is ready for review?

flutter-dashboard · 2026-05-06T16:24:26Z

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

vashworth · 2026-05-06T16:24:40Z

Saw you are still updating this PR. Just double check if this is ready for review?

Let me make sure the tests pass first

hellohuanlin · 2026-05-07T15:13:36Z

Is PR description up to date? If not, could you update for the ease of review and for future reference?

vashworth · 2026-05-07T15:43:42Z

Is PR description up to date? If not, could you update for the ease of review and for future reference?

Done. This PR has kind of evolved. Let me know if you want me to break it up.

hellohuanlin · 2026-05-07T16:36:48Z

Is PR description up to date? If not, could you update for the ease of review and for future reference?

Done. This PR has kind of evolved. Let me know if you want me to break it up.

Yes, breaking it up would make the review easier, and also helps future readers. Thank you!

…Interpreter (flutter#186378) Pass `XcodeBasedProject` instead of the project path string. This will enable us to be able to get more information about the project (other than just the project path) from places in `xcodeproj.dart`. Needed for flutter#185218, https://github.com/flutter/flutter/pull/186006/changes#r3191012567 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

This PR moves the logic for `prefetchSwiftPackages` from the `XcodeProjectInterpreter` class to the `XcodeBasedProject` class so that it can be run per platform Incremental step toward flutter#185218. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Parse common SwiftPM errors

fbf2831

vashworth added 2 commits April 29, 2026 11:00

Merge remote-tracking branch 'upstream/main' into issue_184021

0f633dc

++

552cf55

flutter-dashboard Bot added the CICD Run CI/CD label Apr 29, 2026

++

abaed9b

github-actions Bot removed the CICD Run CI/CD label Apr 30, 2026

vashworth added the CICD Run CI/CD label Apr 30, 2026

vashworth marked this pull request as ready for review April 30, 2026 20:27

vashworth requested review from a team as code owners April 30, 2026 20:27

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/ios/xcodeproj.dart Outdated

Comment thread packages/flutter_tools/lib/src/macos/swift_package_manager.dart Outdated

hellohuanlin marked this pull request as draft April 30, 2026 21:42

++

54c62da

github-actions Bot removed the CICD Run CI/CD label May 1, 2026

++

1164c3d

flutter-dashboard Bot added the CICD Run CI/CD label May 1, 2026

++

532a164

github-actions Bot removed the CICD Run CI/CD label May 1, 2026

++

b3cb95e

flutter-dashboard Bot added the CICD Run CI/CD label May 1, 2026

vashworth marked this pull request as ready for review May 1, 2026 19:12

gemini-code-assist Bot reviewed May 1, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/macos/swift_package_manager.dart

Comment thread packages/flutter_tools/lib/src/macos/swift_package_manager.dart

Merge remote-tracking branch 'upstream/main' into issue_184021

6c5c75b

vashworth commented May 5, 2026

View reviewed changes

var name

906b817

flutter-dashboard Bot added the CICD Run CI/CD label May 5, 2026

fix tests

d49164b

github-actions Bot removed the CICD Run CI/CD label May 5, 2026

vashworth added the CICD Run CI/CD label May 5, 2026

vashworth mentioned this pull request May 5, 2026

Filter out SwiftPM schemes when fetching schemes #186006

Merged

fix tests

97a9ad4

github-actions Bot removed the CICD Run CI/CD label May 5, 2026

vashworth added the CICD Run CI/CD label May 6, 2026

fix test

05e6127

github-actions Bot removed the CICD Run CI/CD label May 6, 2026

vashworth added the CICD Run CI/CD label May 6, 2026

Merge remote-tracking branch 'upstream/main' into issue_184021

037399e

github-actions Bot removed the CICD Run CI/CD label May 6, 2026

vashworth added the CICD Run CI/CD label May 6, 2026

vashworth requested a review from hellohuanlin May 6, 2026 18:18

vashworth changed the title ~~Parse common SwiftPM errors~~ Parse common SwiftPM errors and only fetch Swift packages when project is using SwiftPM May 7, 2026

vashworth mentioned this pull request May 11, 2026

Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter #186378

Merged

10 tasks

vashworth mentioned this pull request May 13, 2026

Move prefetchSwiftPackages to be per platform #186468

Merged

10 tasks

LongCatIsLooong marked this pull request as draft May 14, 2026 21:33

Conversation

vashworth commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard Bot commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

vashworth May 5, 2026

Choose a reason for hiding this comment

Uh oh!

vashworth May 5, 2026

Choose a reason for hiding this comment

Uh oh!

hellohuanlin commented May 6, 2026

Uh oh!

flutter-dashboard Bot commented May 6, 2026

Uh oh!

vashworth commented May 6, 2026

Uh oh!

hellohuanlin commented May 7, 2026

Uh oh!

vashworth commented May 7, 2026

Uh oh!

hellohuanlin commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented Apr 17, 2026 •

edited

Loading