[fuchsia] Place FFI callback stub into the package.#185307
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Apr 29, 2026
Merged
[fuchsia] Place FFI callback stub into the package.#185307auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
github-actions
Bot
added
engine
rmacnak-google
force-pushed
the
fuchsia-new-blob
branch
from
402f822 to
0c3175f
Compare
rmacnak-google
force-pushed
the
fuchsia-new-blob
branch
from
0c3175f to
8cf82fe
Compare
rmacnak-google
force-pushed
the
fuchsia-new-blob
branch
from
8cf82fe to
2261888
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces FFI callback stub generation for Fuchsia Dart and Flutter runners and refactors resource destination paths to explicitly include the 'data/' prefix. Review feedback suggests adding a parameter assertion to the new GN template for consistency, simplifying redundant string interpolation, and including the '--enable_mirrors=false' flag to align the Flutter runner's stub generation with the Dart runner's implementation.
jason-simmons
approved these changes
Apr 29, 2026
rmacnak-google
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Flutter side of https://dart-review.googlesource.com/c/sdk/+/495840. The Flutter side should be submitted first, i.e., make the blob available before trying to use it.
Most of the diff is making explicit that previously existing resources go under /pkg/data so that the new resource can go under /pkg/lib like ELF shared libraries do.