Run tests in `selectable_region_context_menu_test.dart` by Renzo-Olivares · Pull Request #185380 · flutter/flutter

Renzo-Olivares · 2026-04-21T23:17:28Z

Fixes an issue where selectable_region_context_menu_test.dart tests were being skipped.

flutter test --platform=chrome /..../selectable_region_context_menu_test.dart always defaults to TargetPlatform.android and tests were being explicitly skipped on TargetPlatform.android since they do not support the browser context menu at this time. Because TargetPlatform.android is the default then that means every tests in this file was being skipped.

This change fixes the issue by leveraging the variant member of testWidgets instead of the skip member that was being used to explicitly skip tests on TargetPlatform.android. Now we run tests on TargetPlatform.android but only for the supported variants (linux, mac, windows, fuschia).

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request refactors the platform-specific testing logic in selectable_region_context_menu_test.dart by replacing a boolean check with TargetPlatformVariant. Feedback indicates that several tests now lack the necessary skip condition for non-web environments, which will lead to failures due to package:web dependencies. It is also suggested to use a final variable for the variant definition instead of a getter to optimize performance by avoiding redundant allocations.

gemini-code-assist · 2026-04-22T23:12:13Z

+
+    final int numberOfStyleElements = getNumberOfStyleElements();
+    expect(numberOfStyleElements, 1);
+  }, variant: _browserContextMenuEnabledVariants);


The removal of the kIsWeb check will cause this test to fail when run on the VM because it depends on package:web (e.g., web.HTMLElement). Please restore the skip condition to ensure it only runs in a browser environment. The // [intended] comment is also standard practice in this repository for intentional skips. Alternatively, if this file is intended to be web-only, you could add @TestOn('browser') at the top of the file.

}, variant: _browserContextMenuEnabledVariants, skip: !kIsWeb); // [intended]

@TestOn('browser') // This file contains web-only library. library;

already exists at the top of file.

gemini-code-assist · 2026-04-22T23:12:13Z

+
+    final int numberOfStyleElements = getNumberOfStyleElements();
+    expect(numberOfStyleElements, 1);
+  }, variant: _browserContextMenuEnabledVariants);


The removal of the kIsWeb check will cause this test to fail when run on the VM because it depends on package:web. Please restore the skip condition to ensure it only runs on the web.

}, variant: _browserContextMenuEnabledVariants, skip: !kIsWeb); // [intended]

@TestOn('browser') // This file contains web-only library. library;

already exists at the top of file.

gemini-code-assist · 2026-04-22T23:12:13Z

+    expect(selectWordEvent, isNotNull);
+    expect((selectWordEvent!.globalPosition.dx - 200).abs() < precisionErrorTolerance, isTrue);
+    expect((selectWordEvent.globalPosition.dy - 300).abs() < precisionErrorTolerance, isTrue);
+  }, variant: _browserContextMenuEnabledVariants);


The removal of the kIsWeb check will cause this test to fail when run on the VM because it depends on package:web. Please restore the skip condition to ensure it only runs on the web.

}, variant: _browserContextMenuEnabledVariants, skip: !kIsWeb); // [intended]

@TestOn('browser') // This file contains web-only library. library;

already exists at the top of file.

gemini-code-assist · 2026-04-22T23:12:13Z

+      element.dispatchEvent(event);
+      expect(event.defaultPrevented, isTrue);
+    }
+  }, variant: _browserContextMenuEnabledVariants);


The removal of the kIsWeb check will cause this test to fail when run on the VM because it depends on package:web. Please restore the skip condition to ensure it only runs on the web.

}, variant: _browserContextMenuEnabledVariants, skip: !kIsWeb); // [intended]

@TestOn('browser') // This file contains web-only library. library;

already exists at the top of file.

gemini-code-assist · 2026-04-22T23:12:13Z

+TargetPlatformVariant get _browserContextMenuEnabledVariants => TargetPlatformVariant(
+  <TargetPlatform>{...TargetPlatformVariant.desktop().values, TargetPlatform.fuchsia},
+);


Defining the variant as a final variable is preferred over a getter to avoid redundant allocations of the TargetPlatformVariant and its underlying Set on every test case execution.

final TargetPlatformVariant _browserContextMenuEnabledVariants = TargetPlatformVariant( <TargetPlatform>{...TargetPlatformVariant.desktop().values, TargetPlatform.fuchsia}, );

References

Suggest simplification and refactoring to enhance maintainability. ^(link)

fluttergithubbot · 2026-04-23T05:13:55Z

An existing Git SHA, b850ed19b0e9e2b98927474766bb7d1af9c34b24, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

loic-sharma · 2026-04-23T20:30:19Z

+    TargetPlatform.linux,
+    TargetPlatform.macOS,
+    TargetPlatform.windows,
+  },


I wonder if we should do something like:

const TargetPlatformVariant _browserContextMenuEnabledVariants = TargetPlatformVariant( TargetPlatform.values .where((platform) => platform != TargetPlatform.android && platform != TargetPlatform.iOS ) .toSet(), );

This would make sure this opt-out continues to work even if we add more TargetPlatforms in the future. I don't feel strongly though, I'd be happy with the current approach too.

Good point sgtm!

loic-sharma

LGTM!

loic-sharma

Re-LGTM

auto-submit · 2026-04-24T05:36:16Z

autosubmit label was removed for flutter/flutter/185380, because - The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

Renzo-Olivares added the CICD Run CI/CD label Apr 21, 2026

github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 21, 2026

Renzo-Olivares mentioned this pull request Apr 21, 2026

SelectableText and SelectionArea do not work correctly when calling document.execCommand("copy") unless you right-click #182756

Open

Renzo-Olivares marked this pull request as ready for review April 22, 2026 23:10

gemini-code-assist Bot reviewed Apr 22, 2026

View reviewed changes

github-actions Bot removed the CICD Run CI/CD label Apr 23, 2026

Renzo-Olivares added CICD Run CI/CD labels Apr 23, 2026

DanTup mentioned this pull request Apr 23, 2026

Update hidden clipboard input on web when 'copy' event is fired #185476

Draft

10 tasks

Renzo Olivares added 2 commits April 23, 2026 17:14

Actually run tests

c7a71e0

updates

5c2d61c

Renzo-Olivares force-pushed the selectable-region-context-menu-test-fix branch from b850ed1 to 5c2d61c Compare April 23, 2026 17:14

flutter-dashboard Bot removed the CICD Run CI/CD label Apr 23, 2026

Renzo-Olivares added the CICD Run CI/CD label Apr 23, 2026

Renzo-Olivares requested a review from loic-sharma April 23, 2026 17:15

loic-sharma reviewed Apr 23, 2026

View reviewed changes

loic-sharma previously approved these changes Apr 23, 2026

View reviewed changes

apply reviewer suggestion

a7b9503

Renzo-Olivares dismissed loic-sharma’s stale review via a7b9503 April 23, 2026 21:56

github-actions Bot removed the CICD Run CI/CD label Apr 23, 2026

Renzo-Olivares requested a review from loic-sharma April 23, 2026 21:56

loic-sharma reviewed Apr 24, 2026

View reviewed changes

loic-sharma approved these changes Apr 24, 2026

View reviewed changes

Renzo-Olivares added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 24, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2026

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2026

auto-submit Bot added this pull request to the merge queue Apr 24, 2026

Merged via the queue into flutter:master with commit 3249e7d Apr 24, 2026
94 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2026

Conversation

Renzo-Olivares commented Apr 21, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented Apr 23, 2026

Uh oh!

loic-sharma Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

loic-sharma left a comment •

edited

Loading