Skip to content

Reverts "Update libimobiledevice and dependencies (#181932)"#185385

Merged
auto-submit[bot] merged 1 commit intomasterfrom
revert_e166967d22c75843b491cbaf4a478befd4d16bad
Apr 22, 2026
Merged

Reverts "Update libimobiledevice and dependencies (#181932)"#185385
auto-submit[bot] merged 1 commit intomasterfrom
revert_e166967d22c75843b491cbaf4a478befd4d16bad

Conversation

@auto-submit
Copy link
Copy Markdown
Contributor

@auto-submit auto-submit Bot commented Apr 22, 2026

Reverts: #181932

Initiated by: jmagman

Reason for reverting: #185384

Original PR Author: jmagman

Reviewed By: {vashworth, jtmcdole}

This change reverts the following previous change:
Updates libimobiledevice and related tools and dependencies. Because of recipe update https://flutter-review.googlesource.com/c/recipes/+/73060, these are "fat" binaries which means they contain architectural slices for both x86_64 and arm. On ARM Apple Silicon Macs, these will run natively without requiring Rosetta.

Actual changes:
libimobiledevice/libplist@cf5897a...b7f09cc
openssl/openssl@22dbb17...c1eeb94 (updates to LTS 3.5.4, see #180694)

The other mirrors had no commit changes, but we pushed empty commits to our mirror to force it to build with the new recipe (#182587)

Update dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart to add a test that ensures binaries are fat.

$ SHARD=verify_binaries_pre_codesigned dart dev/bots/test.dart
...
All expected fat binaries verified.
▌15:45:49▐ Test successful.

Confirmed flutter run works on a physical iPhone, so iproxy and friends work.

Fixes #121178

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 22, 2026
@auto-submit auto-submit Bot requested a review from jtmcdole as a code owner April 22, 2026 03:47
@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 22, 2026
@jmagman jmagman added the CICD Run CI/CD label Apr 22, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 22, 2026
Merged via the queue into master with commit a075698 Apr 22, 2026
27 of 29 checks passed
@auto-submit auto-submit Bot deleted the revert_e166967d22c75843b491cbaf4a478befd4d16bad branch April 22, 2026 04:21
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 23, 2026
flutter/flutter@3d0e822...5e4f169

2026-04-22 engine-flutter-autoroll@skia.org Roll Skia from f12c89580766 to 11640d1cbc5c (3 revisions) (flutter/flutter#185418)
2026-04-22 engine-flutter-autoroll@skia.org Roll Packages from 7c8e13e to 4a2091d (2 revisions) (flutter/flutter#185417)
2026-04-22 engine-flutter-autoroll@skia.org Roll Skia from f765937d0639 to f12c89580766 (1 revision) (flutter/flutter#185410)
2026-04-22 engine-flutter-autoroll@skia.org Roll Skia from 635b78342e75 to f765937d0639 (1 revision) (flutter/flutter#185406)
2026-04-22 engine-flutter-autoroll@skia.org Roll Skia from cda2af3f5c2e to 635b78342e75 (3 revisions) (flutter/flutter#185393)
2026-04-22 engine-flutter-autoroll@skia.org Roll Skia from 632a41e2baba to cda2af3f5c2e (3 revisions) (flutter/flutter#185390)
2026-04-22 engine-flutter-autoroll@skia.org Roll Skia from 019de7776cfa to 632a41e2baba (3 revisions) (flutter/flutter#185383)
2026-04-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update libimobiledevice and dependencies (#181932)" (flutter/flutter#185385)
2026-04-22 rmolivares@renzo-olivares.dev Fix SelectableRegion crash when the selection starts in a scrollable child but does not select anything initially (flutter/flutter#184420)
2026-04-21 34871572+gmackall@users.noreply.github.com Fix timeout when `hybrid_android_views` fails `MotionEvent recomposition` (flutter/flutter#185003)
2026-04-21 srawlins@google.com [flutter] Remove dead check on null being in a set of non-nullables (flutter/flutter#184100)
2026-04-21 737941+loic-sharma@users.noreply.github.com Update the text input triage process to route to platform teams (flutter/flutter#185225)
2026-04-21 scheglov@google.com Compatibility bridge for analyzer 12 and 13. (flutter/flutter#185360)
2026-04-21 magder@google.com new_gallery_macos_impeller__transition_perf out of bringup (flutter/flutter#185355)
2026-04-21 engine-flutter-autoroll@skia.org Roll Skia from 21789d5e2fee to 019de7776cfa (9 revisions) (flutter/flutter#185365)
2026-04-21 magder@google.com Update libimobiledevice and dependencies (flutter/flutter#181932)
2026-04-21 magder@google.com platform_view_macos_impeller__start_up out of bringup (flutter/flutter#185354)
2026-04-21 magder@google.com complex_layout_scroll_perf_macos_impeller__timeline_summary out of bringup (flutter/flutter#185356)
2026-04-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LPa7NLiXEZP2A7IwZ... to UdpQnaP5eSaDZd3-i... (flutter/flutter#185359)
2026-04-21 engine-flutter-autoroll@skia.org Roll Packages from 01c505f to 7c8e13e (4 revisions) (flutter/flutter#185361)
2026-04-21 737941+loic-sharma@users.noreply.github.com Improve the error if the tool cannot find the locally built engine (flutter/flutter#184546)
2026-04-21 engine-flutter-autoroll@skia.org Roll Skia from a234f0ed7245 to 21789d5e2fee (1 revision) (flutter/flutter#185349)
2026-04-21 victorsanniay@gmail.com Replace IndexedStack visibility children with _VisibilityScope + ExcludeFocus (flutter/flutter#184884)
2026-04-21 dacoharkes@google.com [data_assets] Try fix #184505 (flutter/flutter#185330)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build idevicesyslog, idevicescreenshot, and iproxy binaries and all dependent libraries with macOS arm64 and x86_64 architectures

2 participants