Revert "Preprovision Android NDK for flavored builds and reuse matchi…

[gmackall]

…ng unflavored NDKs (#183555)"

This reverts commit fb3b552.

See context starting at
#183555 (comment)

This will need a separate g3fix, as the original pr had one

[gemini-code-assist]

Code Review

This pull request removes the tool-side Android NDK preprovisioning logic and the associated printNdkVersion Gradle task, refactoring NDK path resolution and cleaning up related tests and error messages. Feedback indicates that refactoring certain tests to use AndroidSdk.locateAndroidSdk() instead of mocks compromises test hermeticity by relying on the host environment. Additionally, a misleading comment in android_sdk.dart regarding LLVM detection should be corrected to accurately reflect the code's logic.

[gemini-code-assist]

This change significantly reduces test isolation and hermeticity. By removing the AndroidSdk and ProcessManager overrides from testUsingContext (as seen in the changes to lines 966 and 1031) and instead calling AndroidSdk.locateAndroidSdk()!, the tests now depend on the host machine's Android SDK installation and environment variables. Furthermore, without the ProcessManager override in the context, the code under test will use the real process manager instead of the FakeProcessManager configured in the test, potentially attempting to execute real commands on the host system. These overrides should be restored to ensure the tests remain hermetic and reliable across different environments.

[gemini-code-assist]

The comment // LLVM missing in this NDK version. is misleading because it is located within a block that is only executed when the LLVM executable is found to exist. It should be updated to accurately describe the state.

// LLVM found in this NDK version.

[kyungilcho]

Thanks for catching this. I definitely did not expect the Windows compile hit to be that large, so reverting makes sense.

Looking back, I think the mistake was widening the preprovisioning path into the common unflavored build path instead of keeping it scoped to flavored builds, which was where the original issue was actually showing up.

I’m happy to follow up with a narrower reland that only uses this preprovisioning flow for flavored builds and leaves the unflavored path unchanged.

[kyungilcho]

I have a narrower reland ready locally now.

The change keeps the /preprovisioning path scoped to flavored Android builds only, and leaves the unflavored path unchanged. I’ll open the follow-up PR once this revert lands.

[auto-submit]

autosubmit label was removed for flutter/flutter/185439, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

[flar]

The revert restore the benchmarks:

https://flutter-flutter-perf.luci.app/e/?begin=1775836717&enable_chart_tooltip=true&end=1777051328&keys=X981b9e28cf9efa3fe0cd35316ab7c669&plotSummary=true&use_titles=true&xbaroffset=2807573