Skip to content

Reverts "Roll pub packages (#186224)"#186229

Merged
cbracken merged 1 commit intomasterfrom
revert_e5c4fbab25957efc624ef2cdf01b5392570df7f6
May 8, 2026
Merged

Reverts "Roll pub packages (#186224)"#186229
cbracken merged 1 commit intomasterfrom
revert_e5c4fbab25957efc624ef2cdf01b5392570df7f6

Conversation

@auto-submit
Copy link
Copy Markdown
Contributor

@auto-submit auto-submit Bot commented May 8, 2026

Reverts: #186224

Initiated by: cbracken

Reason for reverting: breaks the tree due to a swift dependency added.

/Volumes/Work/s/w/ir/cache/ruby/.cipd/pkgs/0/pZTfjoFUwZNnilFjCkjEo8rdpdqPNerhy3XDi6ly8kAC/bin/darwin_ruby/lib/ruby/gems/3.1.0/gems/cocoapods-
  1.13.0/bin/pod:55:in `<top (required)>'
                  /Volumes/Work/s/w/ir/cache/ruby/bin/darwin_ruby/bin/pod:36:in `load'
                  /Volumes/Work/s/w/ir/cache/ruby/bin/darwin_ruby/bin
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flutter-pub-roller-bot
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {fluttergithubbot}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR was generated by `flutter update-packages --force-upgrade`.
<!-- end_revert_body -->

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 8, 2026
@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@auto-submit auto-submit Bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 8, 2026
@auto-submit
Copy link
Copy Markdown
Contributor Author

auto-submit Bot commented May 8, 2026

auto label is removed for flutter/flutter/186229, Failed to enqueue flutter/flutter/186229 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected..

@cbracken cbracken added the emergency Jump the queue; land PR in front of all others; only use for emergencies label May 8, 2026
@flutter-dashboard
Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@cbracken cbracken enabled auto-merge May 8, 2026 01:57
@cbracken cbracken added the CICD Run CI/CD label May 8, 2026
@cbracken cbracken added this pull request to the merge queue May 8, 2026
Merged via the queue into master with commit 6ffd48a May 8, 2026
65 of 69 checks passed
@cbracken cbracken deleted the revert_e5c4fbab25957efc624ef2cdf01b5392570df7f6 branch May 8, 2026 02:41
dkajiwara pushed a commit to dkajiwara/flutter that referenced this pull request May 8, 2026
Flutter Gallery was broken by the roll of video_player_avfoundation
2.9.5 in packages roll flutter#186224
(rolled back in flutter#186229). This
was due to adopting Swift in that plugin.

CocoaPods target validation requires either:
* the pod specifies a Swift version.
* the target using it has SWIFT_VERSION set.

We didn't do either. This updates Flutter Gallery to specify this.

Fixes breakage caused in flutter#186224

No tests because gallery itself acts as a test and this effectively
fixes a build error.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants