Skip to content

Clean up host_app_ephemeral_cocoapods Profile build settings#36498

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:release
Jul 19, 2019
Merged

Clean up host_app_ephemeral_cocoapods Profile build settings#36498
jmagman merged 1 commit intoflutter:masterfrom
jmagman:release

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Jul 18, 2019

Description

Missed a FLUTTER_BUILD_MODE while I was doing #35307.

Related Issues

#35302

Tests

None.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow t: xcode "xcodebuild" on iOS and general Xcode project management labels Jul 18, 2019
@jmagman jmagman requested a review from dnfield July 18, 2019 23:23
@jmagman jmagman self-assigned this Jul 18, 2019
dnfield
dnfield approved these changes Jul 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 5e650af into flutter:master Jul 19, 2019
@jmagman jmagman deleted the release branch July 19, 2019 19:49
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@jmagman @johnsonmh
Clean up host_app_ephemeral_cocoapods Profile build settings (flutter…
3ce0796 
…#36498)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @dnfield @googlebot