Skip to content

Add equals and hashCode to Tween#37793

Merged
goderbauer merged 1 commit intoflutter:masterfrom
goderbauer:tweenequals
Aug 7, 2019
Merged

Add equals and hashCode to Tween#37793
goderbauer merged 1 commit intoflutter:masterfrom
goderbauer:tweenequals

Conversation

@goderbauer
Copy link
Copy Markdown
Member

Description

Adds an equals and hashCode method to Tween.

Related Issues

None

Tests

I added the following tests:

  • test that equals work as expected

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 7, 2019
Copy link
Copy Markdown
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks Piinks added the a: animation Animation APIs label Aug 7, 2019
@goderbauer
Copy link
Copy Markdown
Member Author

Tree appears to be green, but dashboard is not updating. Submitting.

@goderbauer goderbauer merged commit b39e315 into flutter:master Aug 7, 2019
@goderbauer goderbauer deleted the tweenequals branch August 7, 2019 22:07
goderbauer added a commit that referenced this pull request Aug 8, 2019
goderbauer added a commit that referenced this pull request Aug 9, 2019
@Hixie
Copy link
Copy Markdown
Contributor

Hixie commented Aug 9, 2019

@tvolkert @Piinks @shihaohong FYI this was reverted because it is unsound to put operator== on mutable objects and unsound for a hashCode to change over the lifetime of an object.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: animation Animation APIs framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants