Added a Driver wait condition for no pending platform messages#39196
Merged
adazh merged 4 commits intoflutter:masterfrom Aug 27, 2019
Merged
Added a Driver wait condition for no pending platform messages#39196adazh merged 4 commits intoflutter:masterfrom
adazh merged 4 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
a: tests
goderbauer
reviewed
Aug 26, 2019
| } | ||
|
|
||
| @override | ||
| BinaryMessenger createBinaryMessenger() { |
Member
There was a problem hiding this comment.
Why do this here as well? I thought you only need it for driver tests?
Contributor
Author
There was a problem hiding this comment.
Right, now we only need it for driver tests.
Initially, it was because this made it much easier for testing this APIs using widget tester. Otherwise, we have to write on-device tests to test this wait condition. Secondly, as Collin/Tong are working on making widget tester work on device, I think this change will actually be beneficial to their work as well. Thus, this change. LMK what you think.
goderbauer
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a Driver wait condition for no pending platform messages.
Related Issues
#37409
Tests
I added the following tests:
extension_test.dart
flutter_driver_test.dart
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?