Skip to content

[Docs] Add missing trailing comma to stateful_widget_scaffold_center template#40555

Merged
johnsonmh merged 1 commit intoflutter:masterfrom
johnsonmh:fix-addTrailingComma
Sep 16, 2019
Merged

[Docs] Add missing trailing comma to stateful_widget_scaffold_center template#40555
johnsonmh merged 1 commit intoflutter:masterfrom
johnsonmh:fix-addTrailingComma

Conversation

@johnsonmh
Copy link
Copy Markdown
Contributor

Description

The trailing comma was missing before, this causes the generated sample code to be formatted unexpectedly.

Before (without trailing comma)

old

After (with trailing comma)

new

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 16, 2019
Copy link
Copy Markdown
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

I think that was the hardest PR I've ever reviewed! :-)

@johnsonmh johnsonmh merged commit 86d200a into flutter:master Sep 16, 2019
@johnsonmh johnsonmh deleted the fix-addTrailingComma branch September 16, 2019 15:47
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants