[Flutter Driver] Simplified the serialization/deserialization logic of the Descendant/…#40715
Merged
adazh merged 3 commits intoflutter:masterfrom Sep 18, 2019
Merged
[Flutter Driver] Simplified the serialization/deserialization logic of the Descendant/…#40715adazh merged 3 commits intoflutter:masterfrom
adazh merged 3 commits intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
This didn't require any changes to tests? |
Contributor
Author
|
Ah, forgot about the find_test.dart. On it. |
Contributor
Author
Tests are updated. |
goderbauer
approved these changes
Sep 18, 2019
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Technically, this is a breaking change for anybody using the API, but that's probably just flutter driver and you?
Contributor
Author
Yep, I think so. |
fb7bdd4 to
5c176b8
Compare
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…f the Descendant/… (flutter#40715) * Simplified the serialization/deserialization logic of the Descendant/Ancestor matchers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Ancestor matchers.
Instead of flattening the "of" and "matching" matchers to the JSON string, using jsonEncode/jsonDecode to convert the matchers to String/from String.
This will make the serialization in Espresso/Java much simpler.
Description
Updated the serialization/deserialization logic for the Descendant/Ancestor matchers. Take the "get_diagnostics_tree" for example.
Before:
{"id":"message-7","method":"ext.flutter.driver","params":{"isolateId":"isolates/4120307314110843","of_keyValueType":"String","of_keyValueString":"TwoTimesCounterContainer","of_finderType":"ByValueKey","matching_type":"Text", "matcher_finderType":
"ByType","finderType":"Descendant","diagnosticsType":"widget","includeProperties":true,"subtreeDepth":20,"command":"get_diagnostics_tree","timeout":10000},"jsonrpc":"2.0"}
After:
{"id":"message-7","method":"ext.flutter.driver","params":{"isolateId":"isolates/4120307314110843","of":"{\"keyValueType\":\"String\",\"keyValueString\":\"TwoTimesCounterContainer\",\"finderType\":\"ByValueKey\"}","matching":"{
\"type\":\"Text\",\"finderType
":\"ByType\"}","finderType":"Descendant","diagnosticsType":"widget","includeProperties":true,"subtreeDepth":20,"command":"get_diagnostics_tree","timeout":10000},"jsonrpc":"2.0"}
Tests
flutter_test test/src/extension_test.dart still passes.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?