Skip to content

Add most of the widget tests; add more web test shards#42807

Merged
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:widgets-web-tests
Oct 16, 2019
Merged

Add most of the widget tests; add more web test shards#42807
yjbanov merged 1 commit intoflutter:masterfrom
yjbanov:widgets-web-tests

Conversation

@yjbanov
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov commented Oct 15, 2019

Description

Add most of the /test/widgets/ tests to the CI matrix and increase the number of Web test shards.

Related Issues

Fixes #41913

@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 15, 2019
Comment thread .cirrus.yml Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have diff number

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment about id

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2019

Codecov Report

Merging #42807 into master will decrease coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42807      +/-   ##
==========================================
- Coverage   60.31%   59.39%   -0.92%     
==========================================
  Files         194      194              
  Lines       18920    18910      -10     
==========================================
- Hits        11412    11232     -180     
- Misses       7508     7678     +170
Flag Coverage Δ
#flutter_tool 59.39% <ø> (-0.92%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/emulator.dart 9.48% <0%> (-61.21%) ⬇️
...kages/flutter_tools/lib/src/ios/ios_emulators.dart 8.69% <0%> (-39.14%) ⬇️
packages/flutter_tools/lib/src/run_hot.dart 38.44% <0%> (-30.03%) ⬇️
...ackages/flutter_tools/lib/src/resident_runner.dart 37.37% <0%> (-20%) ⬇️
packages/flutter_tools/lib/src/run_cold.dart 28.23% <0%> (-15.3%) ⬇️
...ckages/flutter_tools/lib/src/reporting/events.dart 84.5% <0%> (-11.27%) ⬇️
...lutter_tools/lib/src/android/android_emulator.dart 56.25% <0%> (-10.42%) ⬇️
...ges/flutter_tools/lib/src/android/android_sdk.dart 75.09% <0%> (-3.78%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 65.51% <0%> (-3.45%) ⬇️
packages/flutter_tools/lib/src/cache.dart 48.47% <0%> (-0.71%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357d02c...782c1b9. Read the comment docs.

@yjbanov yjbanov merged commit 86f069f into flutter:master Oct 16, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix widget tests and enable them on CI in Web mode

4 participants