Skip to content

Revert: Migrate examples new embedding#43689

Merged
blasten merged 3 commits intoflutter:masterfrom
blasten:revert_embedding
Oct 29, 2019
Merged

Revert: Migrate examples new embedding#43689
blasten merged 3 commits intoflutter:masterfrom
blasten:revert_embedding

Conversation

@blasten
Copy link
Copy Markdown

@blasten blasten commented Oct 29, 2019

Reverts #43643 since it broke some start_up tests and caused #43688.

Unfortunately, I couldn't repro this issue on a Samsung Galaxy.

@blasten blasten requested a review from jmagman October 29, 2019 02:04
@blasten blasten changed the title Revert embedding Revert: Migrate examples new embedding Oct 29, 2019
Copy link
Copy Markdown
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit ea4da39 into flutter:master Oct 29, 2019
@blasten blasten deleted the revert_embedding branch October 29, 2019 02:11
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants