Skip to content

CupertinoPicker minor documentation update#43736

Merged
LongCatIsLooong merged 1 commit intoflutter:masterfrom
LongCatIsLooong:cupertino-picker-docs
Oct 29, 2019
Merged

CupertinoPicker minor documentation update#43736
LongCatIsLooong merged 1 commit intoflutter:masterfrom
LongCatIsLooong:cupertino-picker-docs

Conversation

@LongCatIsLooong
Copy link
Copy Markdown
Contributor

@LongCatIsLooong LongCatIsLooong commented Oct 29, 2019

Description

Be more explicit about setting the initial item in CupertinoPicker's documentation.

Related Issues

Closes #43660

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Oct 29, 2019
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@LongCatIsLooong LongCatIsLooong added the d: api docs Issues with https://api.flutter.dev/ label Oct 29, 2019
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LongCatIsLooong LongCatIsLooong merged commit 3352b91 into flutter:master Oct 29, 2019
@LongCatIsLooong LongCatIsLooong deleted the cupertino-picker-docs branch October 29, 2019 21:31
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CupertinoPicker has no way to set the initial selected item

5 participants