Adjust and refactor all OutlineButton tests into its respective file#44328
Merged
shihaohong merged 1 commit intoflutter:masterfrom Nov 9, 2019
Merged
Adjust and refactor all OutlineButton tests into its respective file#44328shihaohong merged 1 commit intoflutter:masterfrom
OutlineButton tests into its respective file#44328shihaohong merged 1 commit intoflutter:masterfrom
Conversation
shihaohong
approved these changes
Nov 8, 2019
Contributor
shihaohong
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing the refactor :)
Closed
4 tasks
Contributor
Author
|
My pleasure :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing monolithic
buttons_tests.dartfile contains tests for different buttons likeFlatButton,RaisedButton,OutlineButtonandMaterialButton, even thoughflat_button_test.dart,raised_button_test.dart,outline_button_test.dart, andmaterial_button_test.dartexists.This PR splits up and adjusts
OutlineButtontests properly into its respective file.Related Issues
#42798
Tests
I added the following tests:
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?