Skip to content

Adjust and refactor all OutlineButton tests into its respective file#44328

Merged
shihaohong merged 1 commit intoflutter:masterfrom
Inconnu08:outlinebutton_tests
Nov 9, 2019
Merged

Adjust and refactor all OutlineButton tests into its respective file#44328
shihaohong merged 1 commit intoflutter:masterfrom
Inconnu08:outlinebutton_tests

Conversation

@Inconnu08
Copy link
Copy Markdown
Contributor

Description

The existing monolithic buttons_tests.dart file contains tests for different buttons like FlatButton, RaisedButton, OutlineButton and MaterialButton, even though flat_button_test.dart, raised_button_test.dart, outline_button_test.dart, and material_button_test.dart exists.

This PR splits up and adjusts OutlineButton tests properly into its respective file.

Related Issues

#42798

Tests

I added the following tests:

  • Refactors existing

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 7, 2019
@shihaohong shihaohong self-requested a review November 8, 2019 20:08
@shihaohong shihaohong self-assigned this Nov 8, 2019
Copy link
Copy Markdown
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing the refactor :)

@Inconnu08
Copy link
Copy Markdown
Contributor Author

My pleasure :)

@shihaohong shihaohong merged commit 8ad7456 into flutter:master Nov 9, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants