Re-enable docs uploading#44454
Merged
collinjackson merged 4 commits intoflutter:masterfrom Nov 8, 2019
Merged
Conversation
…)" This reverts commit 8f2ea9d.
fluttergithubbot
added
the
c: contributor-productivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Firebase service is sometimes returning 503 errors when we upload docs and that is turning our CI red even though there's nothing wrong on our side.
This change ensures that we'll get better log output when the uploads fail, while keeping the build green even when the Firebase service is down.
It is unfortunate that this could mask failures, but I'm not sure what else can be done on our side at this point. It seems better to attempt uploading rather than not uploading at all.
Related Issues
#44452