Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reland add new enum change (#44281) #44487

Merged
merged 2 commits into from
Nov 14, 2019
Merged

reland add new enum change (#44281) #44487

merged 2 commits into from
Nov 14, 2019

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Nov 9, 2019

This reverts commit ed82bb8.

Description

previous pr is reverted to unblock fuchsia roll
engine: flutter/engine#13767

Related Issues

#39832

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Nov 9, 2019
@chunhtai chunhtai requested a review from xster November 9, 2019 00:26
@chunhtai chunhtai mentioned this pull request Nov 9, 2019
Merged
@xster
Copy link
Member

xster commented Nov 9, 2019

LGTM

@Piinks Piinks added the a: existing-apps Integration with existing apps via the add-to-app flow label Nov 11, 2019
@chunhtai chunhtai merged commit f079491 into flutter:master Nov 14, 2019
iskakaushik pushed a commit to iskakaushik/flutter that referenced this pull request Nov 14, 2019
Revert "reland add new enum change (flutter#44281) (flutter#44487)"
bd66aa0 
This reverts commit f079491.
chunhtai pushed a commit that referenced this pull request Nov 15, 2019
@iskakaushik @chunhtai
Revert "reland add new enum change (#44281) (#44487)" (#44947)
75f3107 
This reverts commit f079491.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster Awaiting requested review from xster

Assignees
No one assigned
Labels
a: existing-apps Integration with existing apps via the add-to-app flow framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chunhtai @xster @googlebot @Piinks @fluttergithubbot