Skip to content

implicit-casts:false in flutter_localizations#45241

Merged
a14n merged 1 commit intoflutter:masterfrom
a14n:implicit-casts-false-flutter_localizations
Dec 11, 2019
Merged

implicit-casts:false in flutter_localizations#45241
a14n merged 1 commit intoflutter:masterfrom
a14n:implicit-casts-false-flutter_localizations

Conversation

@a14n
Copy link
Copy Markdown
Contributor

@a14n a14n commented Nov 20, 2019

Description

Enable implicit-casts:false on flutter_localizations

Related Issues

None

Tests

None because it's a refactoring.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. labels Nov 20, 2019
@HansMuller HansMuller self-requested a review November 22, 2019 19:13
@a14n a14n force-pushed the implicit-casts-false-flutter_localizations branch from 1e189b1 to d9c392a Compare November 25, 2019 20:37
@a14n
Copy link
Copy Markdown
Contributor Author

a14n commented Dec 10, 2019

ping @HansMuller

Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n a14n merged commit 36e599e into flutter:master Dec 11, 2019
@a14n a14n deleted the implicit-casts-false-flutter_localizations branch December 11, 2019 06:27
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants