Skip to content

Feature: ExpandIcon should use the size parameter#45712

Merged
shihaohong merged 3 commits intoflutter:masterfrom
Inconnu08:issue-45692
Dec 10, 2019
Merged

Feature: ExpandIcon should use the size parameter#45712
shihaohong merged 3 commits intoflutter:masterfrom
Inconnu08:issue-45692

Conversation

@Inconnu08
Copy link
Copy Markdown
Contributor

@Inconnu08 Inconnu08 commented Nov 27, 2019

Related Issues

#45692

Tests

I added the following tests:

  • ExpandIcon default size is 24
  • ExpandIcon has the correct given size

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 27, 2019
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@shihaohong shihaohong self-assigned this Dec 6, 2019
@shihaohong
Copy link
Copy Markdown
Contributor

Hi @Inconnu08! Could you add tests to verify for a default behavior ("default size"), as well as passing in a few size values to the ExpandIcon to make sure that changes are expected?

@Inconnu08
Copy link
Copy Markdown
Contributor Author

@shihaohong sorry was a bit busy but here it is

Copy link
Copy Markdown
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong
Copy link
Copy Markdown
Contributor

I restarted the docs-linux test since it seems to be failing for reasons unrelated to your PR. If it fails again, you might have to rebase with master

@shihaohong
Copy link
Copy Markdown
Contributor

Strangely, rerunning the failing docs-linux check caused one checkmark to pass, while the other "failing" checkmark is stuck on the previous run. I'm merging on red and will monitor its progress since it seems like it's the CI having issues rather than an actual failing check.

@shihaohong shihaohong merged commit c5f61ac into flutter:master Dec 10, 2019
@Inconnu08
Copy link
Copy Markdown
Contributor Author

closes #45692

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants