Feature: ExpandIcon should use the size parameter#45712
Feature: ExpandIcon should use the size parameter#45712shihaohong merged 3 commits intoflutter:masterfrom
ExpandIcon should use the size parameter#45712Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Hi @Inconnu08! Could you add tests to verify for a default behavior ("default size"), as well as passing in a few size values to the ExpandIcon to make sure that changes are expected? |
|
@shihaohong sorry was a bit busy but here it is |
|
I restarted the |
|
Strangely, rerunning the failing |
|
closes #45692 |
Related Issues
#45692
Tests
I added the following tests:
ExpandIcon default size is 24ExpandIcon has the correct given sizeChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?